Release v3.9.16

.circleci/build-uitest-config.yml

@@ -89,26 +89,31 @@ jobs:
             echo "$REMOTE_CONFIG_DEFAULTS" | base64 --decode > remote-config-defaults.plist
             echo "$DEBUG_SERVICE_DATA" | base64 --decode > service-data.plist
 
-            # Verify GoogleService-Info.plist was created successfully
-            if [ ! -f "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist was not created!"
-              exit 1
-            fi
-
-            # Verify the file has content and is valid
-            if [ ! -s "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist is empty!"
-              exit 1
-            fi
-
+            # Fail fast on a bad env var here instead of a cryptic
+            # "unable to read input file as a property list" from xcodebuild's
+            # CopyPlistFile step later. Naming the broken var/file points
+            # straight at what to fix in CircleCI's project env vars.
+            check_plist() {
+              if [ ! -s "$2" ] || ! /usr/libexec/PlistBuddy -c "Print" "$2" >/dev/null 2>&1; then
+                echo "ERROR: $1 did not decode to a valid plist -- check its value in CircleCI's project env vars"
+                exit 1
+              fi
+            }
+            check_plist "GOOGLE_SERVICES_PLIST -> GoogleService-Info.plist" GoogleService-Info.plist
+            check_plist "REMOTE_CONFIG_DEFAULTS -> remote-config-defaults.plist" remote-config-defaults.plist
+            check_plist "DEBUG_SERVICE_DATA -> service-data.plist" service-data.plist
+
             echo "GoogleService-Info.plist created successfully:"
             ls -la GoogleService-Info.plist
             echo "File size: $(wc -c < GoogleService-Info.plist) bytes"
-
-            # Display first few lines for debugging (avoid showing sensitive data)
-            echo "GoogleService-Info.plist structure:"
-            head -10 GoogleService-Info.plist
-
+            # Do NOT print file contents here -- this repo is public and
+            # CircleCI build logs for public GitHub repos are viewable
+            # without a CircleCI login by default, so dumping any lines of a
+            # decoded secret (this file's API_KEY, GOOGLE_APP_ID, etc.) would
+            # leak it. check_plist above already validates the content is a
+            # real plist without printing it; that's the right way to verify
+            # this, not head/cat.
+
             # Also copy to brainwallet directory if needed
             mkdir -p ./brainwallet
             cp GoogleService-Info.plist ./brainwallet/PreLaunchResources/

.circleci/config.yml

@@ -86,26 +86,40 @@ jobs:
             echo "$REMOTE_CONFIG_DEFAULTS" | base64 --decode > remote-config-defaults.plist
             echo "$DEBUG_SERVICE_DATA" | base64 --decode > service-data.plist
 
-            # Verify GoogleService-Info.plist was created successfully
-            if [ ! -f "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist was not created!"
+            # Fail fast on a bad env var here instead of a cryptic
+            # "unable to read input file as a property list" from xcodebuild's
+            # CopyPlistFile step later (this exact failure mode hit Xcode
+            # Cloud build 431: DEBUG_SERVICE_DATA didn't decode to a valid
+            # plist). Naming the broken var/file points straight at what to
+            # fix in the CircleCI project env vars.
+            check_plist() {
+              if [ ! -s "$2" ] || ! /usr/libexec/PlistBuddy -c "Print" "$2" >/dev/null 2>&1; then
+                echo "ERROR: $1 did not decode to a valid plist -- check its value in CircleCI's project env vars"
+                exit 1
+              fi
+            }
+            check_plist "GOOGLE_SERVICES_PLIST -> GoogleService-Info.plist" GoogleService-Info.plist
+            check_plist "REMOTE_CONFIG_DEFAULTS -> remote-config-defaults.plist" remote-config-defaults.plist
+            check_plist "DEBUG_SERVICE_DATA -> service-data.plist" service-data.plist
+            # Brainwallet-StoreKit-v1.storekit is JSON (Xcode's StoreKit
+            # Configuration format), not a plist -- plutil -lint rejects JSON
+            # outright, so validate with a real JSON parser instead.
+            if [ ! -s "Brainwallet-StoreKit-v1.storekit" ] || ! python3 -m json.tool Brainwallet-StoreKit-v1.storekit >/dev/null 2>&1; then
+              echo "ERROR: BRAINWALLET_IOS_STOREKIT_V1_0_FILE -> Brainwallet-StoreKit-v1.storekit did not decode to valid JSON -- check its value in CircleCI's project env vars"
               exit 1
             fi
-
-            # Verify the file has content and is valid
-            if [ ! -s "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist is empty!"
-              exit 1
-            fi
-
+
             echo "GoogleService-Info.plist created successfully:"
             ls -la GoogleService-Info.plist
             echo "File size: $(wc -c < GoogleService-Info.plist) bytes"
-
-            # Display first few lines for debugging (avoid showing sensitive data)
-            echo "GoogleService-Info.plist structure:"
-            head -10 GoogleService-Info.plist
-
+            # Do NOT print file contents here -- this repo is public and
+            # CircleCI build logs for public GitHub repos are viewable
+            # without a CircleCI login by default, so dumping any lines of a
+            # decoded secret (this file's API_KEY, GOOGLE_APP_ID, etc.) would
+            # leak it. check_plist above already validates the content is a
+            # real plist without printing it; that's the right way to verify
+            # this, not head/cat.
+
             # Also copy to brainwallet directory if needed
             mkdir -p ./brainwallet
             cp Brainwallet-StoreKit-v1.storekit ./brainwallet/PreLaunchResources/

.circleci/daily-develop-config.yml

@@ -89,26 +89,38 @@ jobs:
             echo "$REMOTE_CONFIG_DEFAULTS" | base64 --decode > remote-config-defaults.plist
             echo "$DEBUG_SERVICE_DATA" | base64 --decode > service-data.plist
 
-            # Verify GoogleService-Info.plist was created successfully
-            if [ ! -f "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist was not created!"
+            # Fail fast on a bad env var here instead of a cryptic
+            # "unable to read input file as a property list" from xcodebuild's
+            # CopyPlistFile step later. Naming the broken var/file points
+            # straight at what to fix in CircleCI's project env vars.
+            check_plist() {
+              if [ ! -s "$2" ] || ! /usr/libexec/PlistBuddy -c "Print" "$2" >/dev/null 2>&1; then
+                echo "ERROR: $1 did not decode to a valid plist -- check its value in CircleCI's project env vars"
+                exit 1
+              fi
+            }
+            check_plist "GOOGLE_SERVICES_PLIST -> GoogleService-Info.plist" GoogleService-Info.plist
+            check_plist "REMOTE_CONFIG_DEFAULTS -> remote-config-defaults.plist" remote-config-defaults.plist
+            check_plist "DEBUG_SERVICE_DATA -> service-data.plist" service-data.plist
+            # Brainwallet-StoreKit-v1.storekit is JSON (Xcode's StoreKit
+            # Configuration format), not a plist -- plutil -lint rejects JSON
+            # outright, so validate with a real JSON parser instead.
+            if [ ! -s "Brainwallet-StoreKit-v1.storekit" ] || ! python3 -m json.tool Brainwallet-StoreKit-v1.storekit >/dev/null 2>&1; then
+              echo "ERROR: BRAINWALLET_IOS_STOREKIT_V1_0_FILE -> Brainwallet-StoreKit-v1.storekit did not decode to valid JSON -- check its value in CircleCI's project env vars"
               exit 1
             fi
-
-            # Verify the file has content and is valid
-            if [ ! -s "GoogleService-Info.plist" ]; then
-              echo "ERROR: GoogleService-Info.plist is empty!"
-              exit 1
-            fi
-
+
             echo "GoogleService-Info.plist created successfully:"
             ls -la GoogleService-Info.plist
             echo "File size: $(wc -c < GoogleService-Info.plist) bytes"
-
-            # Display first few lines for debugging (avoid showing sensitive data)
-            echo "GoogleService-Info.plist structure:"
-            head -10 GoogleService-Info.plist
-
+            # Do NOT print file contents here -- this repo is public and
+            # CircleCI build logs for public GitHub repos are viewable
+            # without a CircleCI login by default, so dumping any lines of a
+            # decoded secret (this file's API_KEY, GOOGLE_APP_ID, etc.) would
+            # leak it. check_plist above already validates the content is a
+            # real plist without printing it; that's the right way to verify
+            # this, not head/cat.
+
             # Also copy to brainwallet directory if needed
             mkdir -p ./brainwallet
             cp Brainwallet-StoreKit-v1.storekit ./brainwallet/PreLaunchResources/

.gitignore

@@ -69,5 +69,9 @@ GoogleService-Info.plist
 Brainwallet-StoreKit-v1.storekit
 /fastlane/report.xml
 **/fastlane/test_output/
-## Games protection 
+## Games protection
 brainwallet/PreLaunchResources/topics_schema.plist
+
+# App Store Connect API credentials (asc-metadata-upload skill)
+.claude/skills/asc-metadata-upload/.env
+*.p8

BrainwalletUITests/LockScreenViewUITests.swift

@@ -36,9 +36,13 @@ final class LockScreenViewUITests: XCTestCase {
         XCTAssertTrue(app.descendants(matching: .any)["Lock Screen Footer View"].exists)
 
         app.activate()
-        app/*@START_MENU_TOKEN@*/.buttons["moon.stars"]/*[[".otherElements",".buttons[\"Clear Night\"]",".buttons[\"moon.stars\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
-        app/*@START_MENU_TOKEN@*/.buttons["sun.max"]/*[[".otherElements",".buttons[\"Brightness Higher\"]",".buttons[\"sun.max\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
-        app/*@START_MENU_TOKEN@*/.buttons["qrcode"]/*[[".otherElements",".buttons[\"Qr Code\"]",".buttons[\"qrcode\"]"],[[[-1,2],[-1,1],[-1,0,1]],[[-1,2],[-1,1]]],[0]]@END_MENU_TOKEN@*/.firstMatch.tap()
+        // Theme toggle: both taps hit the same button (its SF Symbol/label flips
+        // between "moon.stars"/"Clear Night" and "sun.max"/"Brightness Higher"
+        // depending on state), so key off its stable accessibilityIdentifier
+        // instead of the state-dependent auto-generated label.
+        app.buttons["Theme Preference Button"].firstMatch.tap()
+        app.buttons["Theme Preference Button"].firstMatch.tap()
+        app.buttons["QR Code Button"].firstMatch.tap()
 
         let element = app/*@START_MENU_TOKEN@*/.buttons["8"]/*[[".otherElements.buttons[\"8\"]",".buttons[\"8\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.firstMatch
         element.swipeDown()

BrainwalletUnitTests/Buy Receive Tests/NewReceiveTests.swift

@@ -178,15 +178,25 @@ class NewReceiveViewModelTests: XCTestCase {
     // MARK: - Date Formatter Tests
 
     func testISO8601DateFormatterFormat() {
-        // Test the date formatter configuration
+        // Test the date formatter configuration.
+        // Pinned to en_US_POSIX + UTC rather than Locale.current/the system
+        // time zone: this test asserts an English month abbreviation ("jun")
+        // for a date defined in UTC, so both the locale AND the time zone
+        // need to be deterministic. Locale alone isn't enough -- the test
+        // date is June 1 00:00:00 UTC, which is still May 31 in any zone
+        // west of UTC (e.g. US Pacific/Eastern), so without pinning
+        // .timeZone this failed on Xcode Cloud's build agent even after
+        // fixing the locale, since its system time zone renders this same
+        // instant as "31 May" rather than "01 Jun".
         let formatter = DateFormatter()
-        formatter.locale = Locale.current
+        formatter.locale = Locale(identifier: "en_US_POSIX")
+        formatter.timeZone = TimeZone(identifier: "UTC")
         formatter.dateFormat = "dd MMM yyyy HH:mm:ss"
-        
+
         // Test with a known date
         let testDate = Date(timeIntervalSince1970: 1717200000) // June 1, 2024 00:00:00 UTC
         let formattedString = formatter.string(from: testDate).lowercased()
-        
+
         XCTAssertFalse(formattedString.isEmpty)
         XCTAssertTrue(formattedString.contains("2024"))
         XCTAssertTrue(formattedString.contains("jun"))