Skip to content

improve report testing - #147

Merged
rvhonorato merged 1 commit into
windowsfrom
report-test
Sep 9, 2026
Merged

improve report testing#147
rvhonorato merged 1 commit into
windowsfrom
report-test

Conversation

@rvhonorato

@rvhonorato rvhonorato commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

improve test_report.py to use the proper fixtures ipv monkeypatching it. moved the shared fixtures to conftest.py so they are automagically picked up by test_report.py and test_volume.py

@rvhonorato
rvhonorato marked this pull request as ready for review September 8, 2026 16:40
@rvhonorato rvhonorato mentioned this pull request Sep 8, 2026
Merged
@rvhonorato rvhonorato self-assigned this Sep 8, 2026
sverhoeven
sverhoeven approved these changes Sep 9, 2026
View reviewed changes

@sverhoeven sverhoeven left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for removing the monkeypatch code smell.

@rvhonorato
rvhonorato merged commit 47ab0b7 into windows Sep 9, 2026
22 checks passed
@rvhonorato
rvhonorato deleted the report-test branch September 9, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees

@rvhonorato rvhonorato

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvhonorato @sverhoeven