Migrate UI tooling to Vite and Vitest - #95
Conversation
commit: |
Update the UI plugin dependencies and lockfile to the Halo 2.26.0 toolchain, replacing the temporary PR-based bundler package and aligning the workspace configuration. This keeps the plugin on the stable released packages and refreshes the transitive dependency graph.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ca088bc03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? [] | ||
| : [ | ||
| UnoCSS({ | ||
| mode: 'vue-scoped', |
There was a problem hiding this comment.
Preserve UnoCSS output for TypeScript-defined classes
When the custom FormKit model selector is rendered, vue-scoped generates styles only from Vue SFCs, but ui/src/formkit/ai-model-selector-input.ts defines :uno: w-full and :uno: !py-0 outside an SFC. Since this change also removes the global uno.css import, those utilities no longer produce CSS, causing the selector wrapper and input padding styles to regress. Move these utilities into the SFC or retain a global/per-module UnoCSS output for non-Vue sources.
Useful? React with 👍 / 👎.
What does this PR do?
Testing
cd ui && pnpm test:unit— 29 test files, 185 testscd ui && pnpm -C packages/sdk test— 5 test files, 84 testscd ui && pnpm type-checkcd ui && pnpm -C packages/sdk typecheckcd ui && pnpm build-onlygit diff --check./gradlew clean buildNotes
pkg.pr.newbuild for@halo-dev/ui-plugin-bundler-kit@815292f.