fix(cli): push-agent --help, stale --token/--max-samples help, README assets table - #4
Merged
Merged
Conversation
…ADME assets table - `perflens push-agent --help` handed `--help` to ssh as the host and failed with "unknown option -- -". -h/--help now print usage and exit 0; any other argument starting with '-' is a usage error before ssh or scp run. - `--token` help still described the pre-0.10.0 model (agents present a secret in their hello). The server presents the pairing code to the agent via `auth`; a pre-0.10.0 agent's hello token is still accepted with a warning. - `--max-samples` help said the default tops out near 850 MB; the measured plateau at 500000 is near 1.1 GB, as the README and reference already say. - README release-assets table: a prose line between rows orphaned the perflens-tools row. Moved the row into the table, prose after it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small user-facing defects.
Changes
perflens push-agent --helpprinted nothing useful._run_push_agenttookargv[0]as the ssh host unconditionally, so--helpranssh -p 22 ... --helpand failed withssh failed: unknown option -- -.-h/--help(anywhere in the args) now print the usage to stdout and return 0. Any other argument starting with-is a usage error (exit 2) before ssh or scp run, so it can't be parsed as one of their options.--tokenhelp described the pre-0.10.0 model. It said agents must present a shared secret in their hello. Since 0.10.0 the server presents the pairing code to the agent through theauthcommand, and the agent sends no secret. The new text matches the Server CLI table in README/CLAUDE.md, and notes that a pre-0.10.0 agent's hello token is still accepted with a warning. Checked againstauthenticate_agentinagentlink.py(used by both inbound and outbound connections) and SECURITY.md.--max-sampleshelp said 850 MB. The measured plateau at the default 500000 is near 1.1 GB, which README,docs/reference.html, CLAUDE.md and STATUS.md already say.docsContent.tsgives no memory figure, so it needed no change.perflens-tools-linux-{x86_64,aarch64}.tar.gzrow, which rendered as plain text. The row is back in the table, with the prose after it.Unreleased→ Fixed entry.Test plan
pytest tests/: 317 passed, 45 skipped (run withoutsrc/perflens/ui/, as in CI)ruff check src/ tests/ tools/: cleantests/test_cli.pymocksubprocess.runand assert ssh is never invoked for--help,-h,user@host --help(exit 0, usage on stdout), and for--port,-oProxyCommand=true,user@host -p(exit 2, usage on stderr)subprocess.runpush-agent --help→ exit 0;push-agent --bogus→ exit 2;serve --helpshows the new--tokenand--max-samplestext🤖 Generated with Claude Code