BE-838: Restore Atlas package startup after CLI gating - #9616
Open
kostandinang wants to merge 1 commit into
Open
BE-838: Restore Atlas package startup after CLI gating#9616kostandinang wants to merge 1 commit into
kostandinang wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9616 +/- ##
==========================================
- Coverage 65.93% 65.93% -0.01%
==========================================
Files 1886 1886
Lines 198341 198341
Branches 8236 8236
==========================================
- Hits 130772 130771 -1
Misses 66039 66039
- Partials 1530 1531 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@indietyp This issue was created while fixing #9585’s checks. Cause:
Posting for confirmation: is this a relevant fix, or should the PR be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Restore the Atlas package's start script after the Atlas binary was gated behind the
clifeature. Without this, callers such as benchmark setup fail before Atlas starts, including the base comparison for #9585.🔗 Related links
🚫 Blocked by
🔍 What does this change?
--features cliwhen the@rust/hash-graph-atlasstart script invokes Cargo.🏗️ Agent notes
The Atlas binary declares
required-features = ["cli"]. The package script omitted that feature, so Cargo exited withtarget requires the features: cliand the benchmark harness later reported a healthcheck timeout.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
None.
🐾 Next steps
Rerun the benchmark check on #9585 after this reaches
mainso its baseline checkout includes the repaired script.🛡 What tests cover this?
--help; Cargo built and ran the Atlas CLI successfully.❓ How to test this?
mise exec -- yarn workspace @rust/hash-graph-atlas start --help.clifeature.📹 Demo
Not applicable; this repairs an internal start command.
Made with Cursor