Extract Websocket module to avoid CPP - #644
Open
fendor wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
The biggest difference is that we need to wrap the logger again, but I think that's fine. |
Extract optional module that exposes an API for use with websockets. Only exported if the flag `websocket` is enabled.
fendor
force-pushed
the
wip/fendor/websocket-extra-module
branch
from
July 29, 2026 15:16
995357b to
f69b851
Compare
Collaborator
Author
|
@michaelpj and @MangoIV, should we merge this? Or just use the CPP approach? |
Contributor
|
@fendor thanks for doing this. I guess the only thing that I'm worried about is that this is a breaking change. If you don't mind that, I think this is good to go. |
Collaborator
Author
|
I dont mind that 🙃 |
MangoIV
approved these changes
Jul 31, 2026
MangoIV
left a comment
MangoIV
left a comment
Contributor
There was a problem hiding this comment.
yeah looks relatively uncontroversial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract optional module that exposes an API for use with websockets. Only exported if the flag
websocketis enabled.Follow up PR for #643 so we can discuss this further.