fix: V2 delegation notice now names the V2 CLI version that ran - #2027
Merged
Conversation
The dispatcher delegates commands to the V2 `uloop-cli` implicitly, and the stderr notice was the only signal that a V2 CLI ran. "executing in V2 mode" alone did not say which V2 CLI served the command, so a behavior difference against V3 could not be traced back to a concrete version. Include the delegated package and version in the notice, reusing the existing `dispatcherV2CLIPackageName` constant. The notice text is extracted into a pure function so it can be tested without launching node.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe V2 dispatcher now reports the delegated CLI package and resolved version on stderr. A unit test verifies the notice string format. ChangesV2 delegation notice
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
When a Unity project resolves to the V2
io.github.hatayama.uloopmcppackage, the dispatcher silently delegates the command to a V2uloop-cliinstalled in the versioned user cache. The single stderr notice was the only signal that this happened, and it read:That told you the generation but not the version, so when a V3-documented command or option did not behave as expected, there was nothing to point at the concrete CLI that ran. Identifying it meant inspecting the user cache by hand.
The notice now carries the delegated package and version:
The notice stays on stderr and remains one line, so stdout is still exclusively the delegated command's output.
Changes
Verification
scripts/check-go-cli.sh— passes (gofmt, vet, lint with 0 issues across all three modules, and all module tests).