Skip to content

feat: address pause point round 13-14 verification feedback - #2059

Merged
hatayama merged 10 commits into
v3-betafrom
feat/pause-point-feedback-r13-integration
Jul 29, 2026
Merged

feat: address pause point round 13-14 verification feedback#2059
hatayama merged 10 commits into
v3-betafrom
feat/pause-point-feedback-r13-integration

Conversation

@hatayama

@hatayama hatayama commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Addresses pause-point round 13-14 verification feedback across nine focused changes on feat/pause-point-feedback-r13-integration.

Included child PRs

  1. fix: make await-pause-point wait for a new hit on continuous markers #2050fix: make await-pause-point wait for a new hit on continuous markers
  2. fix: separate enable-time patch warnings from pause point hit responses #2051fix: separate enable-time patch warnings from pause point hit responses
  3. feat: report which captured variables were truncated in pause point responses #2052feat: report which captured variables were truncated in pause point responses
  4. feat: accept GameView as an alias for the rendering screenshot capture mode #2053feat: accept GameView as an alias for the rendering screenshot capture mode
  5. fix: hide the input visualization overlay while capturing screenshots #2054fix: hide the input visualization overlay while capturing screenshots
  6. feat: reject simulate input durations above 30 seconds #2055feat: reject simulate input durations above 30 seconds
  7. feat: report discarded mouse input edges when a pause point interrupts simulation #2056feat: report discarded mouse input edges when a pause point interrupts simulation
  8. feat: map dynamic code runtime exception stack frames to user snippet lines #2057feat: map dynamic code runtime exception stack frames to user snippet lines
  9. docs: fill pause point skill gaps found in round 13-14 verification #2058docs: fill pause point skill gaps found in round 13-14 verification

User Impact

  • Continuous/trace await-pause-point waits for a new hit instead of returning a stale one.
  • Hit responses separate enable-time warnings and expose truncation metadata more usefully.
  • Screenshot / simulate / dynamic-code friction from the verification sessions is reduced (GameView alias, overlay hide, duration cap, mouse interrupt wording, exception line numbers).
  • Pause-point skill docs cover the serialize forms, ordering rules, and await semantics that caused repeated session losses.

Test plan

  • Full CI green on this PR (gh pr checks --watch)
  • Pay special attention to Unity 6000.5 package compile (UNITY_6000_4_OR_NEWER paths from screenshot overlay work) and check-release-triggers

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 041f0627-b677-43fe-b0f6-d5144439f5f2

📥 Commits

Reviewing files that changed from the base of the PR and between 5ab8f71 and ccbf608.

⛔ Files ignored due to path filters (5)
  • Assets/Tests/Editor/DynamicCodeToolTests/CompiledAssemblyBuildResultTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/DynamicCodeToolTests/RoslynCompilerBackendTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSimulation/SimulateInputConstants.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/Templates/SharedRoslynCompilerWorkerProgram.cs.template is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/UnityCLILoop.FirstPartyTools.Screenshot.Editor.asmdef is excluded by none and included by none
📒 Files selected for processing (86)
  • .agents/skills/uloop-pause-point/SKILL.md
  • .agents/skills/uloop-pause-point/references/captured-variables.md
  • .agents/skills/uloop-pause-point/references/fast-progressing-games.md
  • .agents/skills/uloop-pause-point/references/troubleshooting.md
  • .agents/skills/uloop-screenshot/SKILL.md
  • .agents/skills/uloop-simulate-keyboard/SKILL.md
  • .agents/skills/uloop-simulate-mouse-input/SKILL.md
  • .agents/skills/uloop-simulate-mouse-ui/SKILL.md
  • .claude/skills/uloop-pause-point/SKILL.md
  • .claude/skills/uloop-pause-point/references/captured-variables.md
  • .claude/skills/uloop-pause-point/references/fast-progressing-games.md
  • .claude/skills/uloop-pause-point/references/troubleshooting.md
  • .claude/skills/uloop-screenshot/SKILL.md
  • .claude/skills/uloop-simulate-keyboard/SKILL.md
  • .claude/skills/uloop-simulate-mouse-input/SKILL.md
  • .claude/skills/uloop-simulate-mouse-ui/SKILL.md
  • .github/workflows/dead-code.yml
  • Assets/Tests/Editor/DynamicCodeToolTests/CompiledAssemblyBuildResultTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/DynamicCodeExecutionResponseFactoryTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/FirstPartyToolSchemaMetadataTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/RoslynCompilerBackendTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/SharedRoslynCompilerWorkerHostTests.cs
  • Assets/Tests/Editor/PausePointCaptureModeTests.cs
  • Assets/Tests/Editor/PausePointStatusResponseContractTests.cs
  • Assets/Tests/Editor/PausePointTests.cs
  • Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointCaptureTests.cs
  • Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointVariableFormatterTests.cs
  • Assets/Tests/PlayMode/MouseInputSimulationResponseFactoryTests.cs
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/SKILL.md
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/references/captured-variables.md
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/references/fast-progressing-games.md
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/references/troubleshooting.md
  • Packages/src/Editor/FirstPartyTools/Common/InputSimulation/SimulateInputConstants.cs
  • Packages/src/Editor/FirstPartyTools/Common/Overlay/AssemblyInfo.cs
  • Packages/src/Editor/FirstPartyTools/Common/Overlay/OverlayCanvasFactory.cs
  • Packages/src/Editor/FirstPartyTools/Compile/CompileSchema.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Compilation/CompiledAssemblyBuildResult.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Compilation/ICompiledAssemblyLoader.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCodeExecutionResponseFactory.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/CompiledAssemblyBuilder.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/CompiledAssemblyLoadService.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/CompiledAssemblyLoader.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeCompiler.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/RoslynCompilerBackend.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/PausePointTools.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointConstants.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointVariableCollector.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointVariableFormatter.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotUseCase.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/KeyboardInputActionExecutor.cs
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/MouseInputMotionActionExecutor.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/MouseInputPressActionExecutor.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/MouseInputSimulationResponseFactory.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateMouseUi/MouseUiPressActionExecutor.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseUi/Skill/SKILL.md
  • Packages/src/Editor/Infrastructure/Api/PausePointStatusBridgeCommand.cs
  • Packages/src/Editor/InternalAPIBridge/GameViewBridge.cs
  • Packages/src/Editor/ToolContracts/UnityCliLoopScreenshotTypes.cs
  • Packages/src/Runtime/PausePoints/UloopCapturedVariable.cs
  • Packages/src/Runtime/PausePoints/UloopPausePointCapturedVariableFrame.cs
  • Packages/src/Runtime/PausePoints/UloopPausePointEntry.cs
  • Packages/src/Runtime/PausePoints/UloopPausePointRegistry.cs
  • Packages/src/Runtime/PausePoints/UloopPausePointSnapshot.cs
  • cli/common/tools/default-tools.json
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/internal/projectrunner/pause_point_await_new_hit_test.go
  • cli/project-runner/internal/projectrunner/pause_point_captured_variable_names_filter.go
  • cli/project-runner/internal/projectrunner/pause_point_captured_variable_names_filter_test.go
  • cli/project-runner/internal/projectrunner/pause_point_enable.go
  • cli/project-runner/internal/projectrunner/pause_point_enable_await_diagnosis_test.go
  • cli/project-runner/internal/projectrunner/pause_point_enable_test.go
  • cli/project-runner/internal/projectrunner/pause_point_enable_time_warning_test.go
  • cli/project-runner/internal/projectrunner/pause_point_errors.go
  • cli/project-runner/internal/projectrunner/pause_point_logs.go
  • cli/project-runner/internal/projectrunner/pause_point_resume_play_test.go
  • cli/project-runner/internal/projectrunner/pause_point_trigger_test.go
  • cli/project-runner/internal/projectrunner/pause_point_types.go
  • cli/project-runner/internal/projectrunner/pause_point_wait.go
  • cli/project-runner/internal/projectrunner/pause_point_wait_poll.go
  • cli/project-runner/internal/projectrunner/pause_point_wait_poll_test.go
  • cli/project-runner/internal/projectrunner/pause_point_wait_test.go
  • cli/project-runner/shared-inputs-stamp.json
  • tests/contracts/pause_point_status_response_contract.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

GameView is a JSON/schema alias for rendering resolved via Enum.TryParse,
so the scanner correctly reports it as an unre referenced public member.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hatayama
hatayama merged commit 62db173 into v3-beta Jul 29, 2026
13 checks passed
@hatayama
hatayama deleted the feat/pause-point-feedback-r13-integration branch July 29, 2026 07:12
@github-actions github-actions Bot mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant