Skip to content

feat: address pause point round 13-14 leftover improvements - #2065

Merged
hatayama merged 4 commits into
v3-betafrom
feat/pause-point-r13-leftovers-integration
Jul 29, 2026
Merged

feat: address pause point round 13-14 leftover improvements#2065
hatayama merged 4 commits into
v3-betafrom
feat/pause-point-r13-leftovers-integration

Conversation

@hatayama

@hatayama hatayama commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Addresses the remaining high-value pause-point Round 13–14 leftovers via four squash-merged child PRs on feat/pause-point-r13-leftovers-integration:

  1. feat: include collider hierarchy paths in Collision2D capture previews #2061feat: include collider hierarchy paths in Collision2D capture previews
  2. feat: serialize watch values with the captured-variable preview serializer #2062feat: serialize watch values with the captured-variable preview serializer
  3. feat: replace unknown-command list with closest-match suggestions #2063feat: replace unknown-command list with closest-match suggestions
  4. test: cover TriggerResult embedding in expired pause point responses #2064test: cover TriggerResult embedding in expired pause point responses

User Impact

  • Collision2D captures expose collider hierarchy paths without an extra execute-dynamic-code round-trip.
  • Watch values use the same collection preview rules as CapturedVariables, with Truncated + freeze-hint caveats when caps hide changes.
  • Unknown-command errors suggest the closest command names instead of listing every command.
  • Expired --trigger waits keep a regression cover for embedded TriggerResult.

Local verification

  • uloop compile on integration: ErrorCount 0 / WarningCount 0
  • scripts/check-go-cli.sh: exit 0
  • Focused EditMode suites for the new/changed tests: all passed
  • Full EditMode on integration: 3 consecutive runs 2422/2430 with the same single failure:
    • WatchExpressionCompilerTests.CompileAsync_ValidExpressionReturnsCompiledEvaluator
    • Unhandled Error log from the shared Roslyn worker (worker_build_failed, CS0012 missing System.Security.Cryptography.Primitives / HashAlgorithmName)
    • Same test passes alone (--filter-type exact)
  • Full EditMode on origin/v3-beta (a404a40a, pre-integration base): also fails the same test once (2412/2420 failed 1). This confirms an existing local environment/shared-worker interaction, not a regression introduced by this round.

Test plan

  • Local compile 0/0
  • Local scripts/check-go-cli.sh
  • Base-branch local full EditMode comparison (origin/v3-beta) — same flake reproduced
  • Full repository CI on this PR
  • Advisor final LGTM before merge

hatayama and others added 4 commits July 29, 2026 18:55
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7198dee4-af28-4cdc-b158-9d7ec986a3d2

📥 Commits

Reviewing files that changed from the base of the PR and between a404a40 and e1c86ea.

⛔ Files ignored due to path filters (4)
  • Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointCollision2DPreviewBuilderTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/WatchHistoryResponseSerializationTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollision2DPreviewBuilder.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Watch/UnityCLILoop.FirstPartyTools.Watch.Editor.asmdef is excluded by none and included by none
📒 Files selected for processing (28)
  • .agents/skills/uloop-pause-point/SKILL.md
  • .agents/skills/uloop-pause-point/references/captured-variables.md
  • .agents/skills/uloop-pause-point/references/watch-expressions.md
  • .claude/skills/uloop-pause-point/SKILL.md
  • .claude/skills/uloop-pause-point/references/captured-variables.md
  • .claude/skills/uloop-pause-point/references/watch-expressions.md
  • Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointCollision2DPreviewBuilderTests.cs
  • Assets/Tests/Editor/WatchHistoryResponseSerializationTests.cs
  • Assets/Tests/Editor/WatchResponseContractTests.cs
  • Assets/Tests/Editor/WatchValueFreezeHintEvaluatorTests.cs
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/SKILL.md
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/references/captured-variables.md
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/references/watch-expressions.md
  • Packages/src/Editor/FirstPartyTools/PausePoint/AssemblyInfo.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollision2DPreviewBuilder.cs
  • Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointVariableFormatter.cs
  • Packages/src/Editor/FirstPartyTools/Watch/WatchTools.cs
  • Packages/src/Editor/FirstPartyTools/Watch/WatchValueFreezeHintEvaluator.cs
  • cli/common/errors/command_suggestions.go
  • cli/common/errors/command_suggestions_test.go
  • cli/common/errors/error_envelope.go
  • cli/common/errors/error_envelope_test.go
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/internal/projectrunner/pause_point_trigger_test.go
  • cli/project-runner/internal/projectrunner/watch_types.go
  • cli/project-runner/shared-inputs-stamp.json
  • tests/contracts/watch_response_contract.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit ce21b4f into v3-beta Jul 29, 2026
15 checks passed
@hatayama
hatayama deleted the feat/pause-point-r13-leftovers-integration branch July 29, 2026 11:46
@github-actions github-actions Bot mentioned this pull request Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant