🐛 Check upstream issue before creating logbook in pr-logbook skill - #101
Conversation
hcross
left a comment
There was a problem hiding this comment.
Verdict: APPROVE-equivalent (posted as COMMENT — GitHub blocks self-approval)
Independent cold-start review by the pr-reviewer agent. No authoring context.
Correctness
Each of the three SKILL.md mirrors (community-config/, .claude/, .gemini/) gains an identical 13-line block in §4 Logbook entries, positioned immediately above the "A logbook is not a status update" paragraph. The block instructs the agent to scan the PR body for Closes #N / Fixes #N / Resolves #N before creating a new logbook issue, and to append a comment + ensure the logbook label if a feature ticket exists.
The three trees stayed in sync. metadata.version correctly bumps 1.1.0 → 1.1.1 in all three files, matching AGENTS.md's convention of signalling contract changes via a version bump.
Convention compliance
- Title — Gitmoji format respected:
🐛 Check upstream issue before creating logbook in pr-logbook skill. The 🐛 emoji matches the framing. - PR body — All four required sections present.
- Branch name —
fix/issue-95-pr-logbook-upstream-checkfollows thefix/prefix convention. - Language — English throughout.
- Logbook — The PR claims #95 carries the logbook entry as a comment with the
logbooklabel, applying the new rule to itself. Intended dogfood test. - Version bump rule — Honoured in all three mirrors.
Test coverage
No automated tests apply (skill content is prose). The live regression test is the self-application: the PR's logbook posted as a comment on #95 rather than a sibling issue. The diff is its own fixture.
Linter findings
lint-markdown.sh community-config/skills/pr-logbook/SKILL.md— exit 0, no output.lint-skill.sh community-config/skills/pr-logbook/SKILL.md(BASE_REF=main) — exit 0, no output. Confirms required frontmatter fields and the version bump vsmain.
Nits (non-blocking)
- The new block names
add_issue_comment(correct MCP tool) withgh issue commentas parenthetical fallback. Consider explicitly noting the MCP tool is preferred per the org's GitHub-MCP-priority rule. Minor. - Out-of-scope items (auto-detect tooling, cross-skill propagation to
pr-reviewer/developer) are appropriately deferred.
Clean change, narrow blast radius, additive guard, self-validating. Ready to merge.
Teaches the
pr-logbookskill to reuse an existing upstream feature issue as the logbook surface instead of spawning a redundant ticket. Implements #95 — the friction it reports is fixed by this very PR, which applies the new rule to itself.How to read this PR?
community-config/skills/pr-logbook/SKILL.md— that is the canonical tree. Read §4 Logbook entries (the only block that changed); the new pre-flight scan forCloses #N/Fixes #N/Resolves #Nsits there..claude/skills/pr-logbook/SKILL.mdand.gemini/skills/pr-logbook/SKILL.mdfiles mirror the same diff for each harness. Spot-check that the three trees stayed in sync.metadata.versionbump (1.1.0 → 1.1.1) in all three files — that is the cheap signal downstream consumers diff against to detect the contract change.pr-reviewer,developerskill tweaks) belongs to earlier merged PRs and is not part of this changeset.How to test this PR?
git fetch origin && git checkout fix/issue-95-pr-logbook-upstream-check.git diff main...HEAD -- '*/pr-logbook/SKILL.md'— confirm the three mirrors carry the identical +13/-1 block and the version bump.Closes #N/Fixes #N/Resolves #Nhappens before anygh issue create.logbooklabel is present. That is the live regression test.Detailed description (for agents)
pr-logbookskill, replicated across three trees (community-config/,.claude/,.gemini/). No code paths, no scripts, no agent definitions touched.metadata.versionline moves from"1.1.0"to"1.1.1".git diff --statreports+13/-1per file.Closes #N,Fixes #N, orResolves #N. If a match exists: (a) append the logbook entry as a comment on issue#Nviaadd_issue_comment(orgh issue comment), (b) ensure#Ncarries thelogbooklabel, adding it viagh issue edit <N> --add-label logbookif absent, (c) do NOT create a standalone logbook issue. Standalone issues remain valid only when no upstream ticket exists (hotfix, dependency bump, ticketless automation run).logbooklabel was added to it. No new logbook issue was created.Closes #Nand route the comment without an agent decision; cross-skill propagation topr-reviewerordeveloper. Both deferred until a second friction report justifies them.