🐛 Add idle-behavior guideline to pr-reviewer and pr-logbook - #102
Merged
Conversation
hcross
commented
May 14, 2026
hcross
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: APPROVE (posted as COMMENT — GitHub blocks self-approval)
Cold-start review. Documentation-only change implementing #96. No blocking issues found; the verdict is approve but submitted as COMMENT because the PR author is also the reviewer's account.
Correctness
- The change adds an
## Idle behaviorsection to two canonical sources and propagates the exact same block to the four mirror files under.claude/and.gemini/. Each mirror is byte-identical to its canonical sibling, matching the PR claim that the trees are kept in lock-step. - Section placement is consistent: in
community-config/agents/pr-reviewer/AGENT.mdit sits between## Out of scopeand## Friction reporting; incommunity-config/skills/pr-logbook/SKILL.mdit sits at end-of-file after## Friction reporting. Both placements are coherent with the surrounding structure. - The guideline matches the friction described in issue #96 ("teammates re-confirm completed tasks in subsequent idle notifications"). The prescribed remedy — single-sentence availability confirmation — is exactly what the curator-clustered issue body recommended.
Convention compliance
- Title
🐛 Add idle-behavior guideline to pr-reviewer and pr-logbookfollows the Gitmoji convention fromAGENTS.md. - Branch
fix/issue-96-teammate-idle-confirmationmatches thefix/prefix rule. - PR body contains all four required sections: human summary, How to read this PR?, How to test this PR?, Detailed description (for agents).
- Logbook: the PR body states the logbook is appended as a comment on #96 per the upstream-issue rule in
community-config/skills/pr-logbook/SKILL.md. Issue #96 is open and carries thelogbooklabel. - Version bumps are present and PATCH-scoped (wording-only addition): AGENT
1.0.0 → 1.0.1, SKILL1.1.1 → 1.1.2. Mirrors carry the same bump.
Test coverage
- Documentation-only PR; no executable code changed. The PR's How to test step 3 (spawn an agent, idle-wake, observe single-sentence reply) is a reasonable manual acceptance check; nothing else is testable.
Linter findings
lint-markdown.sh community-config/agents/pr-reviewer/AGENT.md community-config/skills/pr-logbook/SKILL.md→ exit 0, no output.lint-skill.sh community-config/skills/pr-logbook/SKILL.md→ exit 0, no output. Version bump vsorigin/maindetected, all required frontmatter keys present.lint-skill.sh community-config/agents/pr-reviewer/AGENT.md→ exit 1, but the findings (missing required frontmatter key: name / description / license / compatibility) are a pre-existing script/schema mismatch, not a regression: this linter validates SKILL.md frontmatter (which requireslicenseandcompatibility), while AGENT.md uses a lighter schema. Running it againstorigin/main:community-config/agents/pr-reviewer/AGENT.mdproduces the same output. The PR's own version-bump check passes on AGENT (1.0.0 → 1.0.1detected). Not blocking — worth a follow-up to either add a dedicatedlint-agent.shor teachlint-skill.shto branch ontype: agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a short
Idle behaviorsection to thepr-revieweragent and thepr-logbookskill so teammates confirm availability in one sentence instead of re-summarising a completed task on every idle wake-up. Implements #96.How to read this PR?
Start with the canonical sources — they hold the contract:
community-config/agents/pr-reviewer/AGENT.md— new## Idle behaviorsection, provenance1.0.0 → 1.0.1.community-config/skills/pr-logbook/SKILL.md— new## Idle behaviorsection, provenance1.1.1 → 1.1.2.The matching edits under
.claude/and.gemini/are byte-for-byte mirrors of the canonical change, kept in lock-step so the three distribution trees do not drift. The version bumps are PATCH percommunity-config/skills/pr-logbook/SKILL.md→ Cross-cutting: skill / agent source version bumps (wording-only addition).How to test this PR?
## Idle behaviorblock in each of the six touched files and confirm the wording is identical across the canonical /.claude//.gemini/triplet for each component.bash scripts/check-skill-versions.sh(ortask check-skill-versionsif available) — both bumped sources must pass the version-bump gate.pr-reviewerorpr-logbookagent, let it complete its assigned task, then send an empty wake-up. Expected: a single-sentence availability confirmation, not a re-summary of the completed work.Detailed description (for agents)
community-config/agents/pr-reviewer/AGENT.md: appended## Idle behaviorsection before## Friction reporting; bumpedmetadata.provenance.versionfrom1.0.0to1.0.1.community-config/skills/pr-logbook/SKILL.md: appended## Idle behaviorsection at end-of-file; bumpedmetadata.provenance.versionfrom1.1.1to1.1.2..claude/agents/pr-reviewer/AGENT.md,.gemini/agents/pr-reviewer.md: byte-mirror of the canonical AGENT change..claude/skills/pr-logbook/SKILL.md,.gemini/skills/pr-logbook/SKILL.md: byte-mirror of the canonical SKILL change.git diff --stat origin/main..HEAD).The friction is documented in #96 and the implementation logbook is appended as a comment on the same issue per the upstream-issue logbook rule (
community-config/skills/pr-logbook/SKILL.md→ Logbook entries).Implements #96.