Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动说明
What
JsonFileStore.write()使用独立、排他创建的 UUID 暂存文件。rename失败。Why
原实现固定使用
<target>.tmp。并发写入同一 JSON 文件时,多个调用会互相覆盖暂存内容或争抢同一个 rename 源文件,可能返回STORAGE_WRITE_FAILED,也可能遗留暂存文件。关联 Issue
未发现对应的直接 Issue。本 PR 是针对
JsonFileStore并发持久化边界的独立修复。测试报告(正式审核前必填)
环境
实际执行命令与结果
已知失败 / Baseline(如有)
无已知失败;以上全量共享包测试在本分支通过。
仓库 CI 固定使用 Bun 1.4.2;本地实际使用 Bun 1.4.0,Bun 1.4.2 的 CI 结果待 GitHub Actions 复核。
已提供实际测试命令与 pass/fail 结果
已说明测试环境
如果存在已知 baseline / 环境失败,已提供 main 对照或说明
核心改动已有对应 focused test / smoke / integration 验证
UI 截图(仅可见 UI 变化时必填)
Scope / 后续