ci: run lint and typecheck, and trigger on pushes to master - #217
Merged
Conversation
The workflow only ran `npm test`, and only on pull requests. Lint had no CI protection at all, and nothing type-checked test/ or examples/ — which is how an extensionless import survived in examples/traditional/clientAlerts.GetPublicAlerts.ts until it was caught by hand during the v10 review. Adds the lint and typecheck steps, and a push trigger scoped to master so merges and any direct pushes are verified too. The push filter is limited to master, so PR branches still fire only the pull_request event and nothing runs twice.
jostrander
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Test workflow only ran
npm test, and only on pull requests.npm run lint— lint had no CI protection at all, so the eslint fixes inbeb7e46could regress unnoticed.npm run typecheck— nothing type-checkedtest/orexamples/. That is how an extensionless import survived inexamples/traditional/clientAlerts.GetPublicAlerts.tsuntil it was found by hand during the v10 review;tsconfig.check.jsoncoverssrc,testandexamples.master— merges and any direct pushes are now verified, not just PRs.The
pushfilter is scoped tomaster, so PR branches still fire only thepull_requestevent and nothing runs twice.Test plan
npm run lintclean on masternpm run typecheckclean on masternpm test— 1371 passingpull_requestrun green on this PRpushrun green after merge🤖 Generated with Claude Code