Skip to content

(feat) update hyper to 0.14#74

Open
sunng87 wants to merge 3 commits into
http-rs:mainfrom
sunng87:feature/hyper-014
Open

(feat) update hyper to 0.14#74
sunng87 wants to merge 3 commits into
http-rs:mainfrom
sunng87:feature/hyper-014

Conversation

@sunng87

@sunng87 sunng87 commented Mar 2, 2021

Copy link
Copy Markdown

Fixes #73

@Fishrock123 Fishrock123 added this to the 7.0.0 milestone Mar 2, 2021
@Fishrock123

Copy link
Copy Markdown
Member

This doesn't compile. Can you make sure you run check and tests locally via:

cargo check --no-default-features --features=hyper_client

cargo test --no-default-features --features=hyper_client

@sunng87

sunng87 commented Mar 3, 2021

Copy link
Copy Markdown
Author

Sorry, let me check later today

@sunng87

sunng87 commented Mar 3, 2021

Copy link
Copy Markdown
Author

It seems the main branch doesn't compile on wasm either, due to error from getrandom.

@sunng87

sunng87 commented Mar 4, 2021

Copy link
Copy Markdown
Author

@Fishrock123 it compiles on all targets. However, because the getrandom dependency was introduced in http-types, I'm not sure if it's good to add target check here

@Fishrock123

Copy link
Copy Markdown
Member

@sunng87 Could you add a separate feature flag for this? That we we can land it sooner.

@sunng87

sunng87 commented Apr 23, 2021

Copy link
Copy Markdown
Author

@Fishrock123 I'm not quite sure if a feature flag could fix this. Could you please show me some detail about that?

@Firstyear

Copy link
Copy Markdown

I've just run into this via http-rs/surf#295, is there any action to follow this up?

@Fishrock123

Copy link
Copy Markdown
Member

this could work but needs to be under a versioned flag, e.g. hyper-014

@niklasad1

niklasad1 commented Dec 7, 2021

Copy link
Copy Markdown

@Fishrock123

Do you mean that you prefer a feature flag such as:

[features]
wasm_getrandom = ["getrandom/js"]
wasm_client = ["other features",  "wasm_getrandom"]

Instead of:

[target.'cfg(target_arch = "wasm32")'.dependencies.getrandom]
version = "0.2.2"
features = ["js"]

Otherwise, can you elaborate so we can get this merged soon? :)

@19h

19h commented May 1, 2022

Copy link
Copy Markdown

Please review this PR, it would be great to be able to use surf with Tokio 1.0 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hyper 0.14 support

5 participants