Skip to content

Fix default_logdir import for transformers v5 - #634

Open
elias-aouad wants to merge 2 commits into
huggingface:mainfrom
elias-aouad:fix-default_logdir-import
Open

Fix default_logdir import for transformers v5#634
elias-aouad wants to merge 2 commits into
huggingface:mainfrom
elias-aouad:fix-default_logdir-import

Conversation

@elias-aouad

@elias-aouad elias-aouad commented Apr 28, 2026

Copy link
Copy Markdown

Fix an import for better compatibility with transformers v5

@peter-clark-moj

Copy link
Copy Markdown

would be great if someone could jump on this. given transformers versions <5.3.0 are considered to have a high danger security vulnerability.

@bigabig

bigabig commented Jul 14, 2026

Copy link
Copy Markdown

Please merge this, it would be nice to be able to work with Transformers v5!

@elias-aouad

Copy link
Copy Markdown
Author

@tomaarsen I am pinging you in case you're still a maintainer of this repo. This is a one-liner PR, would it be possible to merge it ? It would help a lot !
Cheers 🍻
PS: Amazing work you did with this repo, it helps a lot :)

@tomaarsen

Copy link
Copy Markdown
Member

Apologies for the delay. I think it might be safer if we used a try-except ImportError as I imagine your new proposal won't work with older transformers versions.

  • Tom Aarsen

@elias-aouad

Copy link
Copy Markdown
Author

Apologies for the delay. I think it might be safer if we used a try-except ImportError as I imagine your new proposal won't work with older transformers versions.

  • Tom Aarsen

Thank you for the reply, it's all done now :)

@elias-aouad

Copy link
Copy Markdown
Author

@tomaarsen sorry for the second ping, the PR is ready now with the try-except logic. It would be of great help if we could merge it 🙏

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants