fix: use actual median for model-card word count - #645
Closed
tonycoder-hub wants to merge 1 commit into
Closed
Conversation
The "Median" row of the Training Set Metrics table was computed as the mean word count. Use statistics.median instead, and relax the model card patterns so they no longer hardcode the mean. Co-authored-by: Tony Coder <407243179@qq.com>
Author
|
Closing as stale — opened on or before 2026-08-17 and still unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetFitModelCardData.set_train_set_metrics labeled a row Min | Median | Max but computed the middle cell as the mean (sum/len). Every generated model card reported an average under Median.
Now uses statistics.median. Test uses counts 2, 3, 4, 11 so median 3.5 and mean 5.0 diverge.
Tests: python3 -m pytest tests/test_model_card.py -q — new test fails on main (Median 5.0) and passes after. Distinct from #643/#644.