Repository navigation
refactor: use sender of AppendEntries for known leader - #3213
Open
jamessmcgivern wants to merge 3 commits into
Open
jamessmcgivern wants to merge 3 commits into
jamessmcgivern wants to merge 3 commits into
Conversation
jamessmcgivern
commented
Oct 3, 2026
akainth015
approved these changes
Oct 4, 2026
akainth015
left a comment
akainth015
left a comment
Member
There was a problem hiding this comment.
Nice find! This Raft implementation has lots of room of optimizations, incl. follower reads (and improvements like snapshotting)
jamessmcgivern
changed the title
jamessmcgivern
commented
Oct 5, 2026
Member
|
PR looks good besides the enforced formatting - btw you can run |
Author
|
flaky test? |
Member
|
I think you may have reformatted with an old Rust version / not nightly? So the diff ended up with a bunch of unrelated reformats. |
Member
|
Eh, yeah I guess nightly rustfmt updated. Perhaps we should not use nightly rustfmt anymore and just stick to the stable. I have pushed the most recent nightly fmt changes to main= |
MingweiSamuel
force-pushed
the
use-sender-of-appendentries-for-known-leader
branch
from
October 5, 2026 20:52
3210b07 to
01ee786
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not think that there is a need for leader id in the AppendEntries request since sender id is already available to the recipient (and used in similar cases). It looks like the sender always uses its own id for leader id in the request.