337 openid connect - #489
Open
kjlippold wants to merge 19 commits into
Open
Conversation
added 12 commits
July 28, 2026 16:07
daniel-slaugh
approved these changes
Aug 5, 2026
daniel-slaugh
left a comment
Contributor
There was a problem hiding this comment.
The approach looks good to me. I think adding your local OIDC test client to the CI pipeline with some additional tests would be helpful. Once CI pipeline is all green, I think this is ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked initial OIDC implementation from https://github.com/hydroserver2/hydroserver/tree/337-OIDC for https://github.com/hydroserver2/hydroserver/tree/release/v2.0.0
Discussion items:
a. session_auth: Django session authentication for use by HydroServer internal frontends.
b. apikey_auth: API keys associated with service accounts for use by non-user workflows.
c. basic_auth: Email/password authentication mainly for use in hydroserverpy.
d. oidc_auth: Token authentication for use by any registered third-party application