Post-review follow-ups from the release-hardening pass - #33
Merged
Conversation
- resumeRotation: an unresolvable current profile ('<None>' selected, or
the manually picked profile deleted) now counts as divergence — there is
no profile the slot could legitimately be on, so the next generation
re-picks and switches instead of draining the stale counter unswitched.
- tryAdvanceFromFailure takes a notify option: startRotation and
skipCurrentSlot pass notify:false since their callers already toast the
returned error — one failed click no longer stacks two error toasts. The
mid-rotation path, which has no caller to report to, keeps its toast.
- numOr() treats null/undefined/'' as missing rather than coercing to 0,
so count/weight fields imported as null prefill their real defaults
(3/2/5/1) instead of a below-min 0; clearing an input now stores the
fallback too.
- Rotation tab mirrors the bar's fix: the status dot hashes only a real
profile name, never the 'unassigned slot' placeholder.
- Scoped the regenerate acceptance criterion to solo chats: group-chat
regenerates are 'normal' end to end at the event level and carry no
signal to filter on; documented as a known limitation.
- TESTING.md criterion 13 describes what bind/unbind actually show (toast +
Rotation-tab select) — a bare command's return value is never displayed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XDAj3aSdkvffKR6ZetqcyV
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six small fixes surfaced by the adversarial review of the PR #32 diff:
<None>(or after the manually picked profile was deleted) now counts as divergence, so the next generation re-picks and switches instead of draining the stale counter with no profile applied.tryAdvanceFromFailuretakes anotifyoption;startRotation/skipCurrentSlotsuppress the internal toast since their callers already surface the returned error. The mid-rotation path keeps its toast (it has no caller to report to).numOrnull handling — nullish/empty count and weight values prefill their real defaults (3/2/5/1) in the editor instead of a below-min0.'normal'end to end at the event level with no signal to filter on; acceptance criterion 6 is now scoped to solo chats.Tests: 15/15 pass (
npm test); all modules parse clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01XDAj3aSdkvffKR6ZetqcyV
Generated by Claude Code