Make merges actually deploy; fix the flaky API test blocking them - #23
Merged
Merged
Conversation
…ocking them
deploy needs test-api and test-web, but both skipped on the merge ("closed")
event, so GitHub skipped deploy too. No merge has deployed since the pipeline
was added. They now also run when a PR is merged, so the deploy still waits on
passing tests.
Also points cloud-services at fix/broadcast-cancellation, which fixes the
test_hub_ws failure that hit about half of the test-api runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployneedstest-apiandtest-web, but both hadif: github.event.action != 'closed', so they skipped on the merge event. GitHub then skips any job whose needs were skipped, and every merge run has finished in about one second with all jobs skipped. Build the web client in CI instead of on EC2 #21 and Serve the web client with nginx and proxy the API #22 (nginx, CI-built web client) are merged but have not reached EC2.test-apiandtest-webnow also run when a PR is merged, sodeployruns and still waits on passing tests.test-hubandtest-uplinkstill skip on merge.cloud-servicesto46e47f2(Stop the broadcaster from losing cancellations on Python 3.11 cloud-services#7). That fixes the intermittenttest_hub_wsfailure, which failedtest-apiin about half of runs and would otherwise randomly block deploys.Merge order
WEB_API_BASE_URLis unset, so the bundle uses the page origin)frontend(vite preview) service, and serves the GUI on :4173main, installs requirements and restartsbackendThe deploy secrets (
EC2_HOST,EC2_PEM_KEY,EC2_USER) are already set.Test plan
test_hub_ws.pyon Python 3.11 went from 50 failures to 0test-apipasses against the bumped submoduletest-api,test-weband thendeployrunning (not skipped), and the deploy job succeedssystemctl is-active nginx backend,curl -s localhost:4173/health, and view-only login works athttp://98.93.47.19:4173🤖 Generated with Claude Code