Skip to content

fix(ci): pin third-party actions to full commit SHAs - #26

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d444edba-9321-4dd8-b5ee-b2e668555d8f

📥 Commits

Reviewing files that changed from the base of the PR and between 4c8d2f8 and 0dfa8a8.

📒 Files selected for processing (3)
  • .github/workflows/agda.yml
  • .github/workflows/codeql.yml
  • .github/workflows/push-email-notify.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (17)
  • GitHub Check: secret-scan / shell-secrets
  • GitHub Check: secret-scan / gitleaks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: secret-scan / rust-secrets
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Workflow security linter
🔇 Additional comments (3)
.github/workflows/agda.yml (1)

37-37: LGTM!

Also applies to: 56-56, 60-60

.github/workflows/codeql.yml (1)

45-45: LGTM!

Also applies to: 48-48, 54-54

.github/workflows/push-email-notify.yml (1)

43-43: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Pinned workflow actions to immutable commit versions while retaining their release labels.
    • Improved the reliability and traceability of automated repository workflows.

Walkthrough

The workflows replace mutable action version tags with immutable commit SHA references. Version comments and existing workflow configuration remain unchanged.

Changes

CI action pinning

Layer / File(s) Summary
Analysis workflow action pinning
.github/workflows/agda.yml, .github/workflows/codeql.yml
The Agda and CodeQL workflows pin action references to commit SHAs. Existing version comments and configuration remain unchanged.
Notification action pinning
.github/workflows/push-email-notify.yml
The SMTP notification action uses the commit SHA for version v0.2.0 instead of its version tag.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarises the main change: pinning third-party CI actions to full commit SHAs.
Description check ✅ Passed The description directly explains the SHA pinning, the Actions policy requirement, the explicit Rust toolchain input, and the intended lack of behavioural changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each workflow line
Exact commits now form the sign
Checkout hops on fixed ground
Notifications stay tightly bound
CI runs with tags pinned down

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) September 19, 2026 23:23
@hyperpolymath
hyperpolymath merged commit 2b0aa6c into main Sep 20, 2026
19 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant