Skip to content

docstring-scan-test calibration commit is a pre-squash PR head, unreachable from main: Self Test red since #1073 #1099

Description

@hyperpolymath

Defect

scripts/tests/docstring-scan-test.sh was added in #1073 (4b2a347). Its calibration step asserts that commit 1cc72cdc80c9 is present. That commit is PR #1034's pre-squash head. #1034 was squash-merged as c56f4ecc, so 1cc72cdc80c9 lives only under refs/pull/1034/head and no clone of main contains it, however deep. The remedy the test prints, "fetch full history", cannot cure it, because Self Test already checks out with fetch-depth: 0.

Measured:

Cure

On a miss, fetch the calibration commit by full SHA, then re-check. Keep the fail-closed bad assertion when the fetch fails.

  • Use git fetch --quiet --no-tags origin <full sha> without --depth. In a complete clone, --depth writes .git/shallow and truncates main's history for every later test in the job.
  • The calibration commit and its CodeRabbit cross-reference (13 functions / 2 files / 0.00% / 3 skipped) stay unchanged.

Acceptance criteria

  • docstring-scan-test.sh passes in CI on a fetch-depth: 0 checkout of main, and the calibration row reports files=2, functions=13, documented=0, skipped=3, coverage=0.00%.
  • In a clone without network access to the object, the test still FAILS on the calibration row. A skip is not a pass.
  • The checkout is still not shallow after the test runs (no .git/shallow in the common dir).
  • Self Test is green on main after the cure lands.

The cure is folded into #1088. It can't land separately under the fully-green rule, because a standalone PR would be red on #1088's other cures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QYY8Gp4v4x2J7iSNn1vZ57

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaves incorrectly

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions