fix(core): compute the profile statistics Aggregate_Profile never assigned - #67
Merged
Merged
Conversation
…igned Aggregate_Profile computed means only: Std_Dev_ISA, Median_ISA, Category_Std_Devs, Category_Medians and Evaluated_At were returned uninitialized, and reports printed that undefined memory as real statistics. The E2E assertion Std_Dev_ISA >= 0.0 failed nondeterministically on stack garbage (first caught on PR #63, the first CI runs after the #66 gate repair; GNAT warned at vexometer-core.adb:100 all along). Std deviations use the two-pass form -- summed squared deviations cannot go negative, unlike E[x^2] - E[x]^2. Medians sort a copy. Numeric record components now default to zero so the N = 0 path returns defined values. Verified: 1282/1282 assertions pass, three consecutive runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
added a commit
that referenced
this pull request
Sep 1, 2026
## Summary Closes out the 2026-09-01 decode-and-repair pass with the situation report and the last mechanical documentation fixes. Everything narrative lives in the sitrep itself: **docs/sitrep-2026-09-01.adoc**. - **Sitrep** — repo/branch state and the lossless rebase resolution, the quality-gate outage (#66) and the two defects the repaired gates caught immediately (#67 uninitialized profile statistics, #64 unparseable workflow-linter), the verified Anthropic-paper provenance and the ISA/safety-alignment boundary, a documentation honesty audit, and a debt register (D1–D7) with done-conditions. - **STATE.a2ml** — `last-updated` refreshed; the 25%-vs-70% divergence and the assertion-execution counting convention annotated (true refresh = D3). - **SATELLITES.adoc** — dead `.scm` links repointed to `.machine_readable/6a2/*.a2ml`; retired-format NOTE on the ECOSYSTEM.scm template section. - **vexometer-satellites/README.adoc** — false claim to hold the protocol specs removed; dead `docs/*-format.adoc` links repointed to the real specs; trust manifest regenerated in the same commit per the manifest contract. - **TEST-NEEDS.adoc** — the 1282 figure annotated as assertion executions (420 loop-amplified), ~55 static sites. ## Verification - `bash scripts/run-must-gates.sh` → exit 0, "all must gates passed" (with the regenerated vexometer-satellites manifest). - All links added here resolve on this branch; no `link:*.scm` remains in SATELLITES.adoc. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aggregate_Profilecomputed means only.Std_Dev_ISA,Median_ISA,Category_Std_Devs,Category_MediansandEvaluated_Atwere returned uninitialized, andvexometer-reports.adbprints those fields into CSV/HTML/LaTeX/text reports — so every generated report carried undefined memory as real statistics.Why now
The E2E assertion
Std_Dev_ISA >= 0.0failed nondeterministically on PR #63 — the first CI test runs in this repo's history, enabled by the #66 gate repair. Identical sources passed on #64/#65/#66 and failed on #63: classic uninitialized-read behaviour (GNAT warned"Profile" may be referenced before it has a valueatvexometer-core.adb:100all along; that warning is now gone).How
E[x²] − E[x]².Ada.Containers.Generic_Array_Sort), correct for odd and even N.Model_Profilenow default to zero, so theN = 0path returns defined values.Evaluated_Atis stamped withAda.Calendar.Clock.Verification
just testinvexometer/: 1282/1282 assertions pass, three consecutive runs, exit 0 each (previously flaky). No manifest-tracked files touched.🤖 Generated with Claude Code