Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 3, 2026 06:16
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With auto-conversion enabled, both integer setters cast through
floatbefore writing a floating-point setting'sdoublestorage. This loses precision unnecessarily: assigning16777217stores16777216, although the original value is exactly representable as a double.Convert directly to
double, matching__config_setting_get_float. The change preserves the setting type and disabled-auto-conversion behavior.The regression covers both setters, ordinary values, positive and negative values above float's exact-integer range, boundary neighbors, and rejected writes leaving the value unchanged.
Validation
Tested on Linux x86_64 with GCC 14.2 and CMake 4.4.3, based on
1e2dedd046f5119e67b0ccbda5916e8aff55c142:git diff --checkpassesWindows, macOS, 32-bit targets, embedded hardware, and Autotools builds were not tested locally. Normal integer-to-double rounding remains for values not exactly representable as double.