Fix TopicManager shutdown deadlock with connected clients - #214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closing Runtime or Unreal with a topic client still connected can hang indefinitely. TopicManager::Stop holds manager_lock_ while nng_close waits for the disconnect callback, and that callback calls UnsubscribeAll, which needs the same lock.
Change
Release the topic-data lock while joining the receiver and closing the socket. A separate lifecycle mutex serializes complete Start/Stop transitions, and repeated calls are harmless. Reacquire the data lock before resetting socket and callback state.
Add bounded subprocess regressions covering connected clients, pending receive frames, concurrent Stop calls, and repeated Start/Stop cycles. A watchdog fails the child after 10 seconds instead of hanging the test runner.
Validation