#2764: Add regression test for duplicate assembly references - #4050
Merged
Conversation
A merging obfuscator can leave a module referencing two versions of the same assembly. Loading both split every type they declare into two definitions that compare unequal, so a signature naming such a type through one reference stopped matching a base method naming it through the other, and a genuine override was printed as virtual. ac0ef8a (#3253) dropped the lower-version duplicates, but nothing covered that, and neither of the existing fixture kinds can carry the three assemblies the situation needs. Assisted-by: Claude:claude-opus-5[1m]:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A merging obfuscator can leave a module referencing two versions of the same assembly. Loading both split every type they declare into two definitions that compare unequal, so a signature naming such a type through one reference stopped matching a base method naming it through the other, and a genuine override was printed as virtual. ac0ef8a (#3253) dropped the lower-version duplicates, but nothing covered that, and neither of the existing fixture kinds can carry the three assemblies the situation needs.
Assisted-by: Claude:claude-opus-5[1m]:Claude Code