Require spec references and design sign-off for engine changes - #4051
Merged
Conversation
C# semantics reconstructed from the model's own knowledge look plausible and are wrong in the corners, so a feature needs the speclets to work from and the real compilers to check the reading against. Where a transform belongs -- ILAst or C# AST, pipeline position, resolver or type system -- is a maintainer's call, not one for the model to settle mid-task.
christophwille
approved these changes
Aug 26, 2026
siegfriedpammer
commented
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C# semantics reconstructed from the model's own knowledge look plausible and are wrong in the corners, so a feature needs the speclets to work from and the real compilers to check the reading against. Where a transform belongs -- ILAst or C# AST, pipeline position, resolver or type system -- is a maintainer's call, not one for the model to settle mid-task.