feat(updater): make update hook timeout configurable - #1
Draft
folex wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This starts the Velopack fork needed to simplify Studio installation. Windows before-update and after-update hooks now have a 60-second default instead of 15 seconds, with a bounded runtime override from 1 to 300 seconds.
The timeout can be set with
VELOPACK_UPDATE_HOOK_TIMEOUT_SECONDSor the updater's--hookTimeoutSecondsoption. The CLI value wins. Invalid environment values log a warning and fall back to 60 seconds.Elevated updates pass the resolved value explicitly to the child process. The parent wait now reserves 10 minutes for update work plus two hook timeout windows, so the maximum valid hook configuration cannot exhaust the parent wait by itself.
Install and uninstall hook limits are unchanged. Removing Studio's scheduled tasks remains follow-up work after this fork is published and consumed.
Validation
cargo test -p velopack_bins- 25 passed, 1 ignored across library, updater, and integration tests.cargo clippy -p velopack_bins --lib --bin update- passed.cargo build -p velopack_libc- passed and regenerated the C header.git diff --check- passed.Post-Deploy Monitoring & Validation
Update Hook Timeout,Hook executed successfully, andProcess timed out after.Known Residuals