Skip to content

Fixing the pipeline - #7

Open
nathan-probert wants to merge 16 commits into
mainfrom
final-pipeline
Open

Fixing the pipeline#7
nathan-probert wants to merge 16 commits into
mainfrom
final-pipeline

Conversation

@nathan-probert

@nathan-probert nathan-probert commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

Closes issue #6
image

After mingw32-make health_check_fix (or make health_check_fix)
image

@nathan-probert

Copy link
Copy Markdown
Contributor Author

Note: Test cases have not yet been updated/created

zachale
zachale previously approved these changes Sep 21, 2024
@nathan-probert
nathan-probert marked this pull request as ready for review September 22, 2024 23:37
faisal-fawad
faisal-fawad previously approved these changes Sep 23, 2024

@faisal-fawad faisal-fawad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachale zachale left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only gave quick review, this code + my branch was used on prod no issue.
Will get my branch PR ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants