fix(core): cache XML serializers - #141
Open
wforney wants to merge 1 commit into
Open
Conversation
Avoid repeated XmlSerializer construction in XDocument deserialization. Assisted-by: OpenAI:GPT-5.6 Luna
SummarySummary
CoverageSharedCode.Core - 27.4%
SharedCode.Core.Tests - 98.1%
SharedCode.Data - 8.3%
SharedCode.Data.Tests - 100%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves performance in SharedCode.Core XML utilities by caching XmlSerializer instances used when deserializing an XDocument, reducing repeated XmlSerializer construction on hot paths.
Changes:
- Added a per-type
XmlSerializercache inXDocumentExtensions. - Routed
Deserialize<T>to reuse cached serializers instead of constructing a new one per call.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+42
to
+58
| if (XmlSerializers.TryGetValue(type.TypeHandle, out var serializer)) | ||
| { | ||
| return serializer; | ||
| } | ||
|
|
||
| lock (XmlSerializers) | ||
| { | ||
| if (XmlSerializers.TryGetValue(type.TypeHandle, out serializer)) | ||
| { | ||
| return serializer; | ||
| } | ||
|
|
||
| serializer = new XmlSerializer(type); | ||
| XmlSerializers.Add(type.TypeHandle, serializer); | ||
| } | ||
|
|
||
| return serializer; |
Comment on lines
+11
to
+15
| /// <summary> | ||
| /// Cached XML serializers by runtime type. | ||
| /// </summary> | ||
| private static readonly Dictionary<RuntimeTypeHandle, XmlSerializer> XmlSerializers = []; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches XmlSerializer instances used by XDocument deserialization to avoid repeated construction on hot paths.