ref(l10n_do_banks): drop uninstall entries already covered by PR #69 - #73
Closed
fernando-pcg wants to merge 1 commit into
Closed
ref(l10n_do_banks): drop uninstall entries already covered by PR #69#73fernando-pcg wants to merge 1 commit into
fernando-pcg wants to merge 1 commit into
Conversation
The five windiescorp modules added in 1ad5291 were already queued in the open PR "uninstall more windiescorp modules on the 19.0 upgrade", which inserts them in alphabetical order inside the same block. Merging both would list every one of them twice. Revert that part and leave the entries to the earlier PR. The corrupted asset cleanup from a012878 is untouched: that was the piece actually missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Los cinco módulos windiescorp que entraron en
1ad5291ya estaban en el PR #69, que los inserta en orden alfabético dentro del mismo bloque desrc/l10n_do_banks/19.0.1.0.0/pre-modules-uninstall.py. Si se mergean los dos, cada uno queda listado dos veces:account_multicurrency_reconcile_patchpurchase_discountwebsite_base_filter_attributewebsite_product_brandswebsite_product_sorting_and_shoppingEste PR revierte esa parte y deja las entradas al PR #69, que es donde estaban primero.
La limpieza de activos corruptos de
a012878queda intacta: esa era la pieza que efectivamente faltaba.El duplicado no rompería la migración (el bucle valida
util.module_installedantes de desinstalar, así que la segunda pasada lo omite), pero deja la lista con entradas repetidas.Generated by Claude Code