Log duplicate match values - #722
Merged
Merged
Conversation
jakub-id
requested review from
JanisSaldabols and
adamdickmeiss
as code owners
August 24, 2026 08:58
Contributor
There was a problem hiding this comment.
Pull request overview
Adds matched bibliographic and service values to duplicate-request event logging.
Changes:
- Records lookup values from the matched transaction.
- Extends duplicate-check event data with
matchedValues. - Adds tests for identifier/title and ISBN matches.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
broker/handler/iso18626-handler.go |
Captures values from the matched transaction. |
broker/handler/iso18626-handler_test.go |
Verifies matched values for duplicate requests. |
broker/events/eventmodels.go |
Adds the optional matchedValues event field. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamdickmeiss
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.