Add supply document action - #37
Merged
Merged
Conversation
jakub-id
requested review from
adamdickmeiss,
ihardy,
kurtnordstrom and
skomorokh
as code owners
August 21, 2026 09:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new “Supply document” workflow action to the Flow UI, including primary/secondary action components, translations, and supporting tests. It also updates the patron-requests list route and related tests to use the default state model endpoint.
Changes:
- Added primary + secondary Flow action UIs for the new
supply-documentaction (including validation and action submission). - Added i18n strings for the new action (ui-rs prompt/labels + stripes-reshare action label).
- Switched the patron requests state model query (and updated fixtures/tests) from
returnablestodefault.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui-rs/translations/ui-rs/en.json | Adds ui-rs translations for supply-document prompt/fields and success/error messages. |
| ui-rs/src/routes/ViewRoute.test.js | Updates test fixtures to use stateModel: 'default'. |
| ui-rs/src/routes/PatronRequestsRoute.test.js | Updates mocked state-model endpoint from returnables to default. |
| ui-rs/src/routes/PatronRequestsRoute.js | Updates state-model query endpoint to broker/state_model/models/default. |
| ui-rs/src/routes/EditRoute.test.js | Updates mocked state-model endpoint/fixture naming for default. |
| ui-rs/src/components/Flow/primaryActions/SupplyDocument.test.js | Adds tests for the new primary supply-document action behavior. |
| ui-rs/src/components/Flow/primaryActions/SupplyDocument.js | Implements the primary supply-document action UI (URL + scan confirm + note). |
| ui-rs/src/components/Flow/primaryActions/index.js | Exports the new primary SupplyDocument action component. |
| ui-rs/src/components/Flow/moreActions/SupplyDocument.test.js | Adds tests for the new secondary (modal) supply-document action behavior. |
| ui-rs/src/components/Flow/moreActions/SupplyDocument.js | Implements the secondary (modal) supply-document action UI (URL + note). |
| ui-rs/src/components/Flow/moreActions/index.js | Exports the new secondary SupplyDocument action component. |
| ui-rs/src/components/Flow/actionMeta.js | Adds icon/metadata for the new supply-document action. |
| stripes-reshare/translations/stripes-reshare/en.json | Adds stripes-reshare translation for the supply-document action label. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@skomorokh I have made some changes and tested this locally. LGTM, if you have some more reservations, maybe just address them and let's get this merged ASAP. I'd like to go through the full flow with Mallory on Monday. |
skomorokh
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.