Fix: Harden CI/CD supply chain controls and explicit secret boundaries - #1
Open
magqqgq wants to merge 2 commits into
Open
Fix: Harden CI/CD supply chain controls and explicit secret boundaries#1magqqgq wants to merge 2 commits into
magqqgq wants to merge 2 commits into
Conversation
### Description This PR addresses high- and low-severity findings from the workspace-wide security audit regarding CI/CD supply-chain risks and implicit secret inheritance[cite: 53]. ### Key Changes * **Explicit Secret Boundaries (`.github/workflows/*.yml`, `workflow-templates/*.yml`):** Removed the unsafe `secrets: inherit` behavior and empty `workflow_call` declarations[cite: 53]. The shared, required, development, and template workflows now explicitly declare and pass only the required three-secret interface (`SEMGREP_APP_URL`, `SEMGREP_APP_TOKEN`, and `SDLC_SLACK_NOTIFICATIONS`)[cite: 53, 54, 55, 56, 57]. * **Immutable Action References (`.github/workflows/*.yml`, `workflow-templates/*.yml`):** Replaced mutable reusable-workflow branch references (such as `main` and `release-stable`) with verified, full 40-character commit SHAs to prevent unreviewed supply-chain execution[cite: 53]. The production/release workflows are securely pinned to `d61b052e36d795bf5ed9eeb116b4851cc0bbdcdd`[cite: 54, 56, 57], and the development workflow is pinned to `d0c22c2ca17f94fd70054496c71a63f5eeba75e7`[cite: 55].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses high- and low-severity findings from the workspace-wide security audit regarding CI/CD supply-chain risks and implicit secret inheritance[cite: 53].
Key Changes
.github/workflows/*.yml,workflow-templates/*.yml): Removed the unsafesecrets: inheritbehavior and emptyworkflow_calldeclarations[cite: 53]. The shared, required, development, and template workflows now explicitly declare and pass only the required three-secret interface (SEMGREP_APP_URL,SEMGREP_APP_TOKEN, andSDLC_SLACK_NOTIFICATIONS)[cite: 53, 54, 55, 56, 57]..github/workflows/*.yml,workflow-templates/*.yml): Replaced mutable reusable-workflow branch references (such asmainandrelease-stable) with verified, full 40-character commit SHAs to prevent unreviewed supply-chain execution[cite: 53]. The production/release workflows are securely pinned tod61b052e36d795bf5ed9eeb116b4851cc0bbdcdd[cite: 54, 56, 57], and the development workflow is pinned tod0c22c2ca17f94fd70054496c71a63f5eeba75e7[cite: 55].