Add Win64 IDE build support for Delphi 13 - #112
Open
Bazooper-blip wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi @Bazooper-blip, thanks for the PR! Looks good, when I have some time I will give it a test just to make sure. |
fourls
self-requested a review
July 10, 2026 01:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #109 for Delphi 13.
The Delphi 13 client package can now be built for the 64-bit IDE:
DelphiLintClient370.dproj: Win64 platform enabled, with its own output directory (target/370/Win64) so Win32 and Win64 artifacts don't collide.DelphiLint.IDEContext.pas:TToolsApiEditLineNotifier.LineChangednow matches the ToolsAPI signature, which takesData: IntPtr. Declaring the parameter asIntegerhappens to match on Win32 but fails to compile on Win64 (E2291).Dataonly ever carries tracked line numbers, so it is narrowed at this boundary.DelphiLint.Plugin.pas/DelphiLint.ToolFrame.pas/DelphiLint.Utils.pas: the WebView2 loader directory is now architecture-specific (binfor Win32,bin\win64for Win64), because the x86 and x64WebView2Loader.dllshare a filename and are loaded via PATH.scripts/build.ps1: Delphi versions have aSupportsWin64flag (currently only Delphi 13). For those versions the Win64 BPL is built and packaged asDelphiLintClient-<version>-<name>-Win64.bpl.scripts/TEMPLATE_install.ps1: when the package includes a Win64 BPL, the installer downloads the x64WebView2Loader.dllintobin\win64and registers the BPL underKnown Packages x64, which is the key the 64-bit IDE reads (verified against a live Delphi 13 installation). Cleanup handles both registry keys.Delphi 12 (12.3+) also ships a 64-bit IDE and could be enabled by flipping its
SupportsWin64flag and making the equivalent.dprojchange, but I only have Delphi 13 available to verify, so this PR deliberately keeps 290 Win32-only.Testing: Win32 and Win64 Release builds both compile with Delphi 13; the Win64 output is a valid PE32+ x64 BPL. The DUnitX suite passes at the same rate as master. I have not yet exercised the BPL inside the 64-bit IDE itself.