fix(vsock): remove redundant buffer check - #1019
Merged
Merged
Conversation
sgrams
approved these changes
Sep 1, 2026
sgrams
approved these changes
Sep 1, 2026
Signed-off-by: Pojmaj, Marcin <marcin.pojmaj@intel.com>
mpojmaj
force-pushed
the
fix/remove_redundant_buffer_check
branch
from
September 1, 2026 11:41
283c2f6 to
d1e2f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the check from
Packet::checkand rely on the existing check inrecv_packet_connected, which already validates the payload against the buffer it was read intoMigTD/src/devices/vsock/src/stream.rs
Lines 389 to 393 in f4b93e4
This is the real trust boundary; the protocol.rs addition is redundant as well as incorrect for the split header/payload path.