Skip to content

Stop throwing away make stderr output - #1055

Open
berrange wants to merge 1 commit into
intel:mainfrom
berrange:dont-discard-errors
Open

Stop throwing away make stderr output#1055
berrange wants to merge 1 commit into
intel:mainfrom
berrange:dont-discard-errors

Conversation

@berrange

@berrange berrange commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Calling '$(MAKE)' against a sub-directory, while redirecting the stderr output to /dev/null makes it impossible to debug build failures, as it hides all compiler error messages. Stop sending output to /dev/null, so users can figure out what's wrong when a new compiler release fails to build SGX.

@haitaohuang
haitaohuang requested a review from llly October 30, 2024 23:27
@berrange
Stop throwing away make stderr output
db5f647 
Calling '$(MAKE)' against a sub-directory, while redirecting the
stderr output to /dev/null makes it impossible to debug build
failures, as it hides all compiler error messages. Stop sending
output to /dev/null, so users can figure out what's wrong when
a new compiler release fails to build SGX.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
@berrange
berrange force-pushed the dont-discard-errors branch from 6d786b0 to db5f647 Compare July 24, 2026 10:37
@berrange

berrange commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to resolved conflicts with HEAD

jbdelcuv
jbdelcuv approved these changes Jul 24, 2026
View reviewed changes

@jbdelcuv jbdelcuv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bot-cc1s-branch-sync

bot-cc1s-branch-sync commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Important

🔀 The Intel® SGX SDK codebase has moved

Thank you for your contribution!
The code this pull request modifies now resides in a new repository,1 so, unfortunately, it can no longer be merged here as-is. If your change is still relevant, please re-open it against the SDK repository, where this code is now maintained.

If you have any questions or need assistance migrating, please ask here. As we complete the migration, older pull requests may eventually be closed. No work is lost, though, and you are welcome to re-open your change in the new repository at any time.

Footnotes

  1. The affected sources were migrated from confidential-computing.sgx to the dedicated confidential-computing.sgx.sdk repo. The migration covered the SDK sources (sdk/), shared headers (common/), samples (SampleCode/), and the runtime libraries (psw/urts, psw/enclave_common). ↩

@bot-cc1s-branch-sync bot-cc1s-branch-sync added the repo-migration PR whose files moved to the SGX SDK repo (needs re-targeting) label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbdelcuv jbdelcuv jbdelcuv approved these changes
@llly llly Awaiting requested review from llly
+1 more reviewer
@haitaohuang haitaohuang haitaohuang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

repo-migration PR whose files moved to the SGX SDK repo (needs re-targeting)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@berrange @bot-cc1s-branch-sync @haitaohuang @jbdelcuv