security-fix-5 - #467
Open
shubhangi-shrivastava wants to merge 5 commits into
Open
Conversation
Signed-off-by: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
shubhangi-shrivastava
requested review from
DetiPrudvi08,
alexanderintc,
Copilot,
keerthimuvva52 and
nirint
July 15, 2026 14:51
There was a problem hiding this comment.
Pull request overview
This PR aims to harden the Gough NFA runtime against out-of-bounds reads by validating SOM slot indices before indexing som->slots[...] during report generation.
Changes:
- Added bounds checks around SOM slot indexing in
doReports()to prevent OOB reads whensomslot indices are invalid. - Introduced early-return/skip behavior when encountering invalid SOM slot indices in cached and non-cached reporting paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
Signed-off-by: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
Signed-off-by: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
Signed-off-by: Shubhangi Shrivastava <shubhangi.shrivastava@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.