Array Bounds check for FDR Engine Array - #473
Closed
keerthimuvva52 wants to merge 2 commits into
Closed
Conversation
keerthimuvva52
requested review from
DetiPrudvi08,
alexanderintc,
Copilot,
nirint and
shubhangi-shrivastava
and removed request for
Copilot
July 17, 2026 06:05
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds defense-in-depth validation to prevent out-of-bounds access when executing FDR engines by ensuring engineID values used to index the FDR dispatch table are within bounds.
Changes:
- Introduces
FDR_ENGINE_COUNTas the serialized upper bound for valid FDRengineIDvalues. - Adds runtime bounds checks in
fdrExec()/fdrExecStreaming()before indexing thefuncs[]dispatch table. - Adds database-load-time validation to reject databases containing invalid FDR
engineIDvalues reachable from theRoseEngine.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/fdr/fdr.h | Defines FDR_ENGINE_COUNT to constrain serialized engineID values. |
| src/fdr/fdr.c | Adds engineID bounds checks before indexing the FDR dispatch table. |
| src/database.c | Validates FDR engineID values while validating Rose/HWLM offsets to reject forged DBs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+41
| /** Number of entries in the fdrExec dispatch table (funcs[]). Any serialized | ||
| * FDR engineID must be strictly less than this value. */ | ||
| #define FDR_ENGINE_COUNT 19 |
Comment on lines
+848
to
+851
| assert(fdr->engineID < ARRAY_LENGTH(funcs)); | ||
| if (unlikely(fdr->engineID >= ARRAY_LENGTH(funcs))) { | ||
| return HWLM_SUCCESS; /* reject: forged engineID */ | ||
| } |
| if (unlikely(a.start_offset >= a.len)) { | ||
| ret = HWLM_SUCCESS; | ||
| } else { | ||
| assert(fdr->engineID < ARRAY_LENGTH(funcs)); |
Comment on lines
+307
to
+311
| if (unlikely(off >= rose_size || | ||
| off + sizeof(struct HWLM) > rose_size)) { | ||
| DEBUG_PRINTF("HWLM matcher offset %u out of bounds\n", off); | ||
| return HS_INVALID; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.