fix(frontend): multiple a11y fixes - #3961
Merged
Merged
Conversation
Don't add "Logo" as alt text
- add aria-label to sidebar close button - make the SVG icons as `aria-hidden` so they don't stay in a11y tree - parent button defines action, not icon
The `--space-N` variables used on `Flex` weren't defined. Use tailwind's `px` utility instead.
In future, we may improve the paramameterized routes to include additional details. e.g. Wallet Address Details - [walletAddressId] - Rafiki Admin
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
sidvishnoi
marked this pull request as ready for review
August 6, 2026 14:19
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
aria label on nav
avoid nested nav on desktop
- popup aria fixes - associate checkboxes with labels correctly (keep htmlFor for better screen reader support) - special handling for "All" filter - ensure truncated filter list can be read fully in title at least
use aria-describedby instead of overriding label
also, fixed an input that was marked as disabled but required
mkurapov
approved these changes
Aug 7, 2026
mkurapov
left a comment
Contributor
There was a problem hiding this comment.
Looks good - I did a check across the pages. Thanks Sid!
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Multiple fixes observed in Rafiki Admin Accessibility Report.
Review commit-by-commit.
Context
https://docs.google.com/document/d/17svFl6B1g_189D9kt4NAccPt3pZxRmcJxJNOUMwjcsM/edit
Checklist
fixes #numberuser-docslabel (if necessary)