Skip to content

fix(frontend): multiple a11y fixes - #3961

Merged
mkurapov merged 23 commits into
mainfrom
sidvishnoi/a11y-fixes-1
Aug 11, 2026
Merged

fix(frontend): multiple a11y fixes#3961
mkurapov merged 23 commits into
mainfrom
sidvishnoi/a11y-fixes-1

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented Aug 6, 2026

Copy link
Copy Markdown
Member

Changes proposed in this pull request

Multiple fixes observed in Rafiki Admin Accessibility Report.
Review commit-by-commit.

Context

https://docs.google.com/document/d/17svFl6B1g_189D9kt4NAccPt3pZxRmcJxJNOUMwjcsM/edit

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

Don't add "Logo" as alt text
- add aria-label to sidebar close button
- make the SVG icons as `aria-hidden` so they don't stay in a11y tree - parent button defines action, not icon
The `--space-N` variables used on `Flex` weren't defined. Use tailwind's `px` utility instead.
In future, we may improve the paramameterized routes to include additional details.
e.g. Wallet Address Details - [walletAddressId] - Rafiki Admin
@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 75f70b9
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/6a75bdf37478280008937e03

@github-actions github-actions Bot added pkg: frontend Changes in the frontend package. pkg: mock-ase labels Aug 6, 2026
@sidvishnoi
sidvishnoi marked this pull request as ready for review August 6, 2026 14:19
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 41.23
  • Iterations/s: 13.74
  • Failed Requests: 0.00% (0 of 2479)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test -k -q --vus 4 --duration 1m

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 895 kB 15 kB/s
     data_sent......................: 1.9 MB 32 kB/s
     http_req_blocked...............: avg=6.28µs   min=1.9µs    med=5.19µs   max=285.8µs  p(90)=6.32µs   p(95)=7.03µs  
     http_req_connecting............: avg=340ns    min=0s       med=0s       max=242.89µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=96.33ms  min=7.5ms    med=76.78ms  max=608.96ms p(90)=169.19ms p(95)=190.52ms
       { expected_response:true }...: avg=96.33ms  min=7.5ms    med=76.78ms  max=608.96ms p(90)=169.19ms p(95)=190.52ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2479
     http_req_receiving.............: avg=96.01µs  min=26.85µs  med=82.29µs  max=2.82ms   p(90)=124.08µs p(95)=154.15µs
     http_req_sending...............: avg=35.26µs  min=9.05µs   med=24.85µs  max=1.82ms   p(90)=41.18µs  p(95)=54.78µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=96.2ms   min=7.34ms   med=76.66ms  max=608.82ms p(90)=169.03ms p(95)=190.42ms
     http_reqs......................: 2479   41.228999/s
     iteration_duration.............: avg=290.78ms min=201.79ms med=276.79ms max=880.69ms p(90)=348.18ms p(95)=392.43ms
     iterations.....................: 826    13.737456/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@mkurapov mkurapov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I did a check across the pages. Thanks Sid!

@mkurapov
mkurapov merged commit 27f1713 into main Aug 11, 2026
38 of 58 checks passed
@mkurapov
mkurapov deleted the sidvishnoi/a11y-fixes-1 branch August 11, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: frontend Changes in the frontend package. pkg: mock-ase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants