fix: use constant-time compare for admin/webhook HMAC digests - #3964
Open
SashaMIT wants to merge 1 commit into
Open
fix: use constant-time compare for admin/webhook HMAC digests#3964SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Admin API and POS webhook signature verification compared hex digests with ===, which is not constant-time. IdP secret checks already use crypto.timingSafeEqual. Align HMAC digest compares and docs examples. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
pkg: backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyApiSignatureDigest) and POS webhook HMAC useddigest === signatureDigest(non-constant-time string compare).crypto.timingSafeEqual; align HMAC digest compares the same way (equal-length hex Buffers, fail closed on length/non-hex mismatch).===.Sibling surface to open #3963 (same auth/signature files; EXPIRE units).
Test plan
timingSafeEqualequal/unequal/short/non-hex)pnpm exec jest src/shared/utils.test.ts/packages/authtenant signature tests (needs Docker/testcontainers; not available in this agent environment)Made with Cursor