Fix issue 10769#12286
Open
Alonso-Lopez-1 wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Hi @SchrodingersGat, this is my first contribution to InvenTree. I fixed #10769 by displaying “Damaged” and “Attention Needed” stock status badges in the Build Order and Sales Order allocation dropdowns. Would appreciate a review when you have time. Thank you! |
Member
|
I would suggest a different approach - display the stock status all the time, rather than these complex checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This update displays the "Damaged" and "Attention Needed" badges for parts with this status. This badge is specifically displayed in the drop-down menu within the stock allocation in Build Orders or Sales Orders. Only these two badges are displayed, any other statuses such as "OK" are not. The badge is gated by an opt-in flag so it appears only in these allocation dropdowns and does not leak into other stock-item dropdowns.
Why was this PR needed?
People allocating stock within these order forms needed to know if the stock needed attention or was damaged.
What are the relevant issue numbers?
Closes #10769
Screenshots / Recordings (if applicable)
Build Order allocation dropdown displays "Damaged" and "Attention Needed" badges
Build Order allocation dropdown does not display other status badges
Sales Order allocation dropdown displays "Damaged" and "Attention Needed" badges
Sales Order allocation dropdown does not display other status badges
Does this PR meet the acceptance criteria?