Improve images and embeds - #293
Open
uellenberg wants to merge 3 commits into
Open
Conversation
Contributor
|
You should know that the ioccc.png image comes directly from an IOCCC entry in 2011 by Matt Zucker. That was a special prize for him. The judges at the time stated this on their website iirc. So at the least I guess (but I am not the one to make the decision - this is just an FYI) that part won't be approved, though you clearly put a lot of effort into it and that's great. I don't have any comments on the rest and did not look at anything else. The 'header images' just made me wonder as I remember when it was announced, the new image. |
Contributor
|
Actually try this from the repo top level directory: git grep zucker '*.html'and you'll see what I mean. The image links to that entry itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the header images with some higher-quality renders, and improves social embeds (in particular, entry embeds now contain the abstract and have an embed image, using the youtube thumbnail if possible).