oauth: add endpoints - #96
Merged
Merged
Conversation
The endpoint returns null for any token that isn't valid, so the map values are nullable. Deserializing into a non-optional Token made test_tokens fail on exactly the responses it exists to report on. Also stop skipping expires on serialization; the spec types it as integer|null, always present. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds the token exchange as a normal form-encoded POST, and the authorization endpoint as a URL builder rather than a request: it renders a consent page for a browser and returns its result via the redirect URI, so there is nothing for the client to call. PKCE code_challenge is supplied by the caller to avoid taking on cryptographic dependencies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Generates the PKCE secrets and CSRF state, then carries them in a PendingAuthorization so the token exchange cannot be reached without verifying the returned state and supplying the verifier. Previously both were left to the caller as doc comments. Adds typed OAuth errors so a cancelled authorization is distinguishable from a bad verifier; the generic handler flattened both into a string and dropped error_description. All of oauth is now behind a default-on feature, so clients using a personal token can drop the crypto dependencies with default-features = false. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25