feat: opt-in Data-first PBNode field order - #103
Open
lidel wants to merge 1 commit into
Open
Conversation
Add EncodeOptions with a FieldOrder knob: the zero value keeps the canonical Links-first bytes, DataFirst writes the Data field before Links so streaming readers can process it before links. Package-level Encode/AppendEncode delegate to zero-value options and are byte-for-byte unchanged. Mirrors ipld/js-dag-pb#111. Tests pin both orders to the IPIP-550 fixtures and prove the decoder already accepts either. Refs ipfs/specs#550
This was referenced Aug 31, 2026
rvagg
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
EncodeOptionswith aFieldOrderknob: the zero value keeps the canonicalLinks-first bytes, DataFirst writes theDatafield beforeLinksso streaming readers can process it before links. Package-levelEncode/AppendEncodedelegate to zero-value options and are byte-for-byte unchanged.Mirrors ipld/js-dag-pb#111. Tests pin both orders to the IPIP-550 fixtures and prove the decoder already accepts either.
Refs ipfs/specs#550