test: Give BlockHeader's scalars default initializers - #1681
Merged
Conversation
Six of them had none, so a default-initialized BlockchainTest carried whatever was on the stack. Nothing in production noticed, because the JSON loader fills every field, but a hand-built fixture did: the blockchain runner test reported a genesis block number of 100566652073168 and worked around it with value-initialization. state::BlockInfo, the type this parallels, initializes every scalar.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 176 176
Lines 15995 15995
Branches 3666 3666
=======================================
Hits 15654 15654
Misses 255 255
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Initializes all scalar BlockHeader fields to prevent indeterminate values in hand-built test fixtures.
Changes:
- Adds zero-valued default member initializers.
- Updates the runner fixture to exercise default initialization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/utils/blockchaintest.hpp |
Zero-initializes scalar header fields. |
test/unittests/blockchaintest_runner_test.cpp |
Uses default initialization as a regression canary. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test::BlockHeaderleft six scalars without initializers —difficulty,block_number,gas_limit,gas_used,timestampandbase_fee_per_gas— soBlockchainTest t;carriedwhatever was on the stack. Every other member self-initializes, and
state::BlockInfo, the typethis parallels, has
= 0on all of its, so this was the one gap.Production never noticed because
load_blockchain_tests()fills every field from JSON. Ahand-built fixture did: the blockchain runner test reported a genesis block number of
100566652073168 and worked around it with value-initialization, which this removes — leaving the
test as the canary if a bare scalar ever comes back. Verified by default-initializing a
BlockHeaderinto memory poisoned with0xAA: before, all six held the poison; after, all sixare zero.