Ensure _FillValue attributes in metadata cubes are stored using the same data type as their corresponding datasets. - #309
Open
gshiroma wants to merge 32 commits into
Conversation
…corresponding H5 dataset
nemo794
reviewed
Aug 20, 2026
nemo794
left a comment
nemo794
left a comment
Contributor
There was a problem hiding this comment.
Quick question, but otherwise this makes good progress towards addressing that issue.
Have you created sample outputs of all eight products, and manually checked that the dtypes are now correct for all metadate cubes _FillValue attributes?
bhawkins
approved these changes
Aug 20, 2026
Contributor
Author
|
Add docstrings explaining that the dtype of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #297. It updates
_get_raster_from_hdf5_ds()to ensure that_FillValueattributes in metadata cubes are stored using the same data type as their corresponding datasets.