Skip to content

Remove grid mapping projection from L1 products - #310

Open
gshiroma wants to merge 33 commits into
isce-framework:developfrom
gshiroma:remove_grid_mapping_projection_from_l1_products
Open

Remove grid mapping projection from L1 products#310
gshiroma wants to merge 33 commits into
isce-framework:developfrom
gshiroma:remove_grid_mapping_projection_from_l1_products

Conversation

@gshiroma

@gshiroma gshiroma commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Closes #308.

This PR removes the grid_mapping attribute from the L1 product metadata cubes.

It adds a grid_mapping parameter to _get_raster_from_hdf5_ds(). The parameter must be explicitly provided with the value of the grid_mapping attribute from the corresponding HDF5 dataset. Previously, _get_raster_from_hdf5_ds() always added the grid_mapping attribute with the string value projection, regardless of the level of the input product. If not provided, the attribute is not saved in the output HDF5 dataset.

gshiroma and others added 30 commits July 3, 2025 11:30
@gshiroma
gshiroma requested a review from nemo794 June 18, 2026 18:53

@nemo794 nemo794 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good! Thanks, @gshiroma !

Out of curiosity, have you tested this for all 8 products, to ensure the HDF5 are generated correctly?

Comment thread python/packages/nisar/products/insar/InSAR_L2_writer.py
Comment thread python/packages/nisar/workflows/h5_prep.py
Comment thread python/packages/nisar/workflows/h5_prep.py
@gshiroma

Copy link
Copy Markdown
Contributor Author

Code seems good! Thanks, @gshiroma !

Out of curiosity, have you tested this for all 8 products, to ensure the HDF5 are generated correctly?

Thank you, @nemo794 , I tested it for RSLC, RIFG, and GCOV. It would be great if the reviewers could help testing it as well =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(L1 products) grid_mapping Reference Missing in Metadata Cubes

3 participants