Limit water mask coverage to radar grid extents

[gshiroma]

This PR follows #356 and ensures that the water mask layer has consistent coverage with the other static layers, limited to the extents of the radar grid (RadarGridParameters). This is achieved by using the layover/shadow mask as a “reference fill value layer”. The geocoding of this mask assigns the fill value to areas outside the radar grid, which is then used to identify the corresponding fill values in the water mask layer.

[Tyler-g-hudson]

Some nitpicks;

I'm mainly a little confused about the difference between what this PR does and what the name suggests; The PR seems to mask the layover shadow mask onto the watermask, but the title makes claims about using the extents of the RadarGridParameters which don't seem to be used in the code changes.

[Tyler-g-hudson]

Please also rebase to develop - Brian just pushed a branch that will get rid of these CI failures

[gshiroma]

This is achieved by using the layover/shadow mask as a “reference fill value layer”. The geocoding of this mask assigns the fill value to areas outside the radar grid, which is then used to identify the corresponding fill values in the water mask layer.

Thank you, @Tyler-g-hudson , I updated the PR description to make the intent of this PR clearer:

“This is achieved by using the layover/shadow mask as a ‘reference fill value layer.’ The geocoding of this mask assigns the fill value to areas outside the radar grid, which is then used to identify the corresponding fill values in the water mask layer.”

[Tyler-g-hudson]

“This is achieved by using the layover/shadow mask as a ‘reference fill value layer.’ The geocoding of this mask assigns the fill value to areas outside the radar grid, which is then used to identify the corresponding fill values in the water mask layer.”

Thanks for this clarification - I think it would help to have a brief comment about this in the code near where the layover/shadow mask is passed into the function to explain why it is there.

[gshiroma]

“This is achieved by using the layover/shadow mask as a ‘reference fill value layer.’ The geocoding of this mask assigns the fill value to areas outside the radar grid, which is then used to identify the corresponding fill values in the water mask layer.”

Thanks for this clarification - I think it would help to have a brief comment about this in the code near where the layover/shadow mask is passed into the function to explain why it is there.

Thank you, @Tyler-g-hudson , I added this comment in 79d3a2f.