Skip to content

fix(questhelper): handle locationless detailed steps - #33

Merged
itsBOTzilla merged 1 commit into
mainfrom
fix/questhelper-null-defined-point
Sep 5, 2026
Merged

fix(questhelper): handle locationless detailed steps#33
itsBOTzilla merged 1 commit into
mainfrom
fix/questhelper-null-defined-point

Conversation

@itsBOTzilla

@itsBOTzilla itsBOTzilla commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Treat DetailedQuestStep.getDefinedPoint() as optional in the generic quest executor while preserving existing behavior for located steps. Adds a regression test reproducing the exact null-pointer failure and bumps Quest Helper to 1.0.8. Verification: 91 Quest Helper tests pass, client check passes, and the staged diff check is clean.

Summary by CodeRabbit

  • Bug Fixes

    • Improved Quest Helper stability when handling quest steps without a defined location.
    • Prevented errors during line-of-sight checks and walking actions for locationless steps.
  • Tests

    • Added coverage verifying that locationless quest steps are handled safely.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ce4346ab-ab25-4982-a193-b3a6d0a7c037

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5ff7b and fd18be1.

📒 Files selected for processing (3)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/QuestHelperPlugin.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/QuestScript.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/questhelper/QuestDetailedStepTest.java

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The Quest Helper plugin now handles detailed quest steps without defined locations. It avoids null point access, adds a regression test, and updates the plugin descriptor from version 1.0.7 to 1.0.8.

Changes

Quest step safety

Layer / File(s) Summary
Locationless detailed step handling
runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/QuestScript.java
applyDetailedQuestStep uses a nullable world point and skips point-dependent operations when no location exists.
Regression coverage and plugin version
runelite-client/src/test/java/net/runelite/client/plugins/microbot/questhelper/QuestDetailedStepTest.java, runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/QuestHelperPlugin.java
The test verifies that a locationless detailed step returns false without throwing. The plugin descriptor version changes to 1.0.8.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fd18b

Locationless detailed quest steps no longer crash the quest executor and instead return false, while steps with locations retain their existing behavior. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: handling locationless detailed steps in Quest Helper.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/questhelper-null-defined-point

Comment @coderabbitai help to get the list of available commands.

@itsBOTzilla
itsBOTzilla merged commit 76ecdaa into main Sep 5, 2026
3 checks passed
@itsBOTzilla
itsBOTzilla deleted the fix/questhelper-null-defined-point branch September 5, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant