fix(questhelper): handle locationless detailed steps - #33
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe Quest Helper plugin now handles detailed quest steps without defined locations. It avoids null point access, adds a regression test, and updates the plugin descriptor from version ChangesQuest step safety
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Locationless detailed quest steps no longer crash the quest executor and instead return false, while steps with locations retain their existing behavior. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Treat DetailedQuestStep.getDefinedPoint() as optional in the generic quest executor while preserving existing behavior for located steps. Adds a regression test reproducing the exact null-pointer failure and bumps Quest Helper to 1.0.8. Verification: 91 Quest Helper tests pass, client check passes, and the staged diff check is clean.
Summary by CodeRabbit
Bug Fixes
Tests